From: Ian Campbell <Ian.Campbell@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH v2 1/1] tools/libfsimage: Fix clean and distclean make targets
Date: Mon, 13 May 2013 11:44:44 +0100 [thread overview]
Message-ID: <1368441884.537.48.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1368200034-16055-1-git-send-email-daniel.kiper@oracle.com>
On Fri, 2013-05-10 at 16:33 +0100, Daniel Kiper wrote:
> If there is a single colon for a given target and the target
> is redefined in another place (e.g. in included file) then
> make executes only new target and displays following warning:
>
> Makefile:35: warning: overriding commands for target `clean'
> tools/libfsimage/common/../../../tools/libfsimage/Rules.mk:25:
> warning: ignoring old commands for target `clean'
>
> To cope with that issue define all required targets as double-colon
> rules. Additionally, remove some redundant stuff.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
and pushed
prev parent reply other threads:[~2013-05-13 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 15:33 [PATCH v2 1/1] tools/libfsimage: Fix clean and distclean make targets Daniel Kiper
2013-05-13 10:44 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368441884.537.48.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.