From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 4/4] xen/arm: correctly handle an empty
 array of platform descs.
Date: Tue, 14 May 2013 17:41:05 +0100
Message-ID: <1368549665.14264.60.camel@zakaz.uk.xensource.com>
References: <1368462160.537.125.camel@zakaz.uk.xensource.com>
	<1368462182-10317-4-git-send-email-ian.campbell@citrix.com>
	<alpine.DEB.2.02.1305131748510.4799@kaball.uk.xensource.com>
	<1368523975.14264.22.camel@zakaz.uk.xensource.com>
	<5192248402000078000D5E7F@nat28.tlf.novell.com>
	<1368526880.14264.29.camel@zakaz.uk.xensource.com>
	<5192666A02000078000D60F8@nat28.tlf.novell.com>
	<1368543272.14264.41.camel@zakaz.uk.xensource.com>
	<1368543416.14264.42.camel@zakaz.uk.xensource.com>
	<1368544071.14264.46.camel@zakaz.uk.xensource.com>
	<5192787B02000078000D61D3@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5192787B02000078000D61D3@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "Tim (Xen.org)" <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Julien Grall <julien.grall@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2013-05-14 at 16:46 +0100, Jan Beulich wrote:
> >>> On 14.05.13 at 17:07, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > But if I remove only -DGCC_HAS_VISIBILITY_ATTRIBUTE the issue goes away.
> > 
> > Which makes no sense because the test code has no use of that, but Aha: 
> >         -include 
> > /local/scratch/ianc/devel/arm/xen.git/xen/include/xen/config.h
> > 
> > Which eventually gets us, from compiler.h:
> > #ifdef GCC_HAS_VISIBILITY_ATTRIBUTE
> > /* Results in more efficient PIC code (no indirections through GOT or PLT). 
> > */
> > #pragma GCC visibility push(hidden)
> > #endif
> 
> That's a very interesting (to me at least) side effect of applying
> hidden visibility to symbols.

Indeed, me neither.

I pruned all the other options and it is exactly this pragma plus -O*
which causes this behaviour, even on x86.

Ian.