From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 4/4] xen/arm: correctly handle an empty array of platform descs. Date: Wed, 15 May 2013 10:47:34 +0100 Message-ID: <1368611254.11138.6.camel@hastur.hellion.org.uk> References: <1368462160.537.125.camel@zakaz.uk.xensource.com> <1368462182-10317-4-git-send-email-ian.campbell@citrix.com> <1368523975.14264.22.camel@zakaz.uk.xensource.com> <5192248402000078000D5E7F@nat28.tlf.novell.com> <1368526880.14264.29.camel@zakaz.uk.xensource.com> <5192666A02000078000D60F8@nat28.tlf.novell.com> <1368543272.14264.41.camel@zakaz.uk.xensource.com> <1368543416.14264.42.camel@zakaz.uk.xensource.com> <1368544071.14264.46.camel@zakaz.uk.xensource.com> <5192787B02000078000D61D3@nat28.tlf.novell.com> <1368549665.14264.60.camel@zakaz.uk.xensource.com> <5193518E02000078000D647F@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5193518E02000078000D647F@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "Keir (Xen.org)" , Stefano Stabellini , Ian Jackson , "Tim (Xen.org)" , "xen-devel@lists.xen.org" , Julien Grall List-Id: xen-devel@lists.xenproject.org > As Linux doesn't play with symbol visibility, we're really alone > having this problem, and hence indeed need to go through and > audit all places where the potential for empty ranges exists. The comment says "Results in more efficient PIC code (no indirections through GOT or PLT).", how much PIC code is there in the hypervisor anyway? > But you said "<" instead of "!=" didn't have any surprising side > effects, so quite likely we won't need much code to change. "<" fails because it does process the (non-existent) first entry in the array. This happened to be "safe" in the case I saw but it wouldn't be in general. Ian.