From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 4/4] xen/arm: correctly handle an empty
 array of platform descs.
Date: Wed, 15 May 2013 14:47:00 +0100
Message-ID: <1368625620.11138.37.camel@hastur.hellion.org.uk>
References: <1368462160.537.125.camel@zakaz.uk.xensource.com>
	<1368462182-10317-4-git-send-email-ian.campbell@citrix.com>
	<alpine.DEB.2.02.1305131748510.4799@kaball.uk.xensource.com>
	<1368523975.14264.22.camel@zakaz.uk.xensource.com>
	<5192248402000078000D5E7F@nat28.tlf.novell.com>
	<1368526880.14264.29.camel@zakaz.uk.xensource.com>
	<5192666A02000078000D60F8@nat28.tlf.novell.com>
	<1368543272.14264.41.camel@zakaz.uk.xensource.com>
	<1368543416.14264.42.camel@zakaz.uk.xensource.com>
	<1368544071.14264.46.camel@zakaz.uk.xensource.com>
	<5192787B02000078000D61D3@nat28.tlf.novell.com>
	<1368549665.14264.60.camel@zakaz.uk.xensource.com>
	<5193518E02000078000D647F@nat28.tlf.novell.com>
	<1368611254.11138.6.camel@hastur.hellion.org.uk>
	<5193995402000078000D6733@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5193995402000078000D6733@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "Tim (Xen.org)" <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Julien Grall <julien.grall@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2013-05-15 at 13:19 +0100, Jan Beulich wrote:
> >>> On 15.05.13 at 11:47, Ian Campbell <ian.campbell@citrix.com> wrote:
> 
> >> As Linux doesn't play with symbol visibility, we're really alone
> >> having this problem, and hence indeed need to go through and
> >> audit all places where the potential for empty ranges exists.
> > 
> > The comment says "Results in more efficient PIC code (no indirections
> > through GOT or PLT).", how much PIC code is there in the hypervisor
> > anyway?
> 
> All x86-64 code has been built with -fpic from the beginning. That
> likely was the easiest (and possibly the only available) solution to
> not being able to use -mcmodel=kernel.

I should probably investigate not doing this for ARM, where we don't use
fpic, then!

> >> But you said "<" instead of "!=" didn't have any surprising side
> >> effects, so quite likely we won't need much code to change.
> > 
> > "<" fails because it does process the (non-existent) first entry in the
> > array. This happened to be "safe" in the case I saw but it wouldn't be
> > in general.
> 
> Okay, I misread one of your earlier responses then. Did you do
> the necessary auditing already, or should I put this on my todo
> list?

I haven't done an audit. I put a very quicly grepped list in a previous
mail but it is surely incomplete.

Ian.