From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404Ab3ETI3u (ORCPT ); Mon, 20 May 2013 04:29:50 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:42500 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752110Ab3ETI3t (ORCPT ); Mon, 20 May 2013 04:29:49 -0400 Message-ID: <1369038587.2143.12.camel@joe-AO722> Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling From: Joe Perches To: David Miller Cc: eliezer.tamir@linux.intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jesse.brandeburg@intel.com, donanld.c.skidmore@intel.com, e1000-devel@lists.sourceforge.net, willemb@google.com, andi@firstfloor.org, hpa@zytor.com, eliezer@tamir.org.il Date: Mon, 20 May 2013 01:29:47 -0700 In-Reply-To: <20130520.005447.972811583292360876.davem@davemloft.net> References: <20130519102525.12527.83301.stgit@ladj378.jer.intel.com> <20130519102533.12527.12991.stgit@ladj378.jer.intel.com> <20130520.005447.972811583292360876.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: > From: Eliezer Tamir [] > > { > > struct socket *sock; > > + unsigned int poll_result; > > Please order local variable declarations from longest line to > shortest line. reverse christmas tree doesn't seem especially valuable or sensible for automatics. I'd rather order by first use or even alphabetical, especially with long lists of automatics. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling Date: Mon, 20 May 2013 01:29:47 -0700 Message-ID: <1369038587.2143.12.camel@joe-AO722> References: <20130519102525.12527.83301.stgit@ladj378.jer.intel.com> <20130519102533.12527.12991.stgit@ladj378.jer.intel.com> <20130520.005447.972811583292360876.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: willemb@google.com, eliezer.tamir@linux.intel.com, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, andi@firstfloor.org, donanld.c.skidmore@intel.com, hpa@zytor.com, eliezer@tamir.org.il To: David Miller Return-path: In-Reply-To: <20130520.005447.972811583292360876.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: > From: Eliezer Tamir [] > > { > > struct socket *sock; > > + unsigned int poll_result; > > Please order local variable declarations from longest line to > shortest line. reverse christmas tree doesn't seem especially valuable or sensible for automatics. I'd rather order by first use or even alphabetical, especially with long lists of automatics. ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired