From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Myklebust, Trond" Subject: Re: [PATCH 09/13] NFS:Add labels to client function prototypes Date: Mon, 20 May 2013 19:24:40 +0000 Message-ID: <1369077843.6115.31.camel@leira.trondhjem.org> References: <1368719808-14584-1-git-send-email-SteveD@redhat.com> <1368719808-14584-10-git-send-email-SteveD@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List To: Steve Dickson Return-path: In-Reply-To: <1368719808-14584-10-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: <0B227CCBC520834EA1A6E68272D845D5-c5HhxtLuC0z3oGB3hsPCZA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2013-05-16 at 11:56 -0400, Steve Dickson wrote: > From: Steve Dickson > > >From David Quigley > > After looking at all of the nfsv4 operations the label structure has been added > to the prototypes of the functions which can transmit label data. > Why do helpers like nfs_post_op_update_inode() need to be here? Also, instead of converting functions like nfs_refresh_inode() that are used absolutely everywhere, why not make special versions, nfs_refresh_labeled_inode() for those call sites that actually do use labels? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:57472 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154Ab3ETTYm convert rfc822-to-8bit (ORCPT ); Mon, 20 May 2013 15:24:42 -0400 From: "Myklebust, Trond" To: Steve Dickson CC: "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List Subject: Re: [PATCH 09/13] NFS:Add labels to client function prototypes Date: Mon, 20 May 2013 19:24:40 +0000 Message-ID: <1369077843.6115.31.camel@leira.trondhjem.org> References: <1368719808-14584-1-git-send-email-SteveD@redhat.com> <1368719808-14584-10-git-send-email-SteveD@redhat.com> In-Reply-To: <1368719808-14584-10-git-send-email-SteveD@redhat.com> Content-Type: text/plain; charset=US-ASCII MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, 2013-05-16 at 11:56 -0400, Steve Dickson wrote: > From: Steve Dickson > > >From David Quigley > > After looking at all of the nfsv4 operations the label structure has been added > to the prototypes of the functions which can transmit label data. > Why do helpers like nfs_post_op_update_inode() need to be here? Also, instead of converting functions like nfs_refresh_inode() that are used absolutely everywhere, why not make special versions, nfs_refresh_labeled_inode() for those call sites that actually do use labels? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com