All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: jaeyong.yoo@samsung.com
Cc: Julien Grall <julien.grall@linaro.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: Bug report and patch about IRQ freezing after gic_restore_state
Date: Tue, 21 May 2013 14:00:09 +0100	[thread overview]
Message-ID: <1369141209.21246.63.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20628360.525981369134828242.JavaMail.weblogic@epv6ml03>

On Tue, 2013-05-21 at 11:13 +0000, 유재용 wrote:
> > > Signed-off-by: Jaeyong Yoo 
> > > --- 
> > >  xen/arch/arm/domain.c |    4 ++-- 
> > >  xen/arch/arm/gic.c    |    4 ++-- 
> > >  2 files changed, 4 insertions(+), 4 deletions(-) 
> > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c 
> > > index f71b582..2c3b132 100644 
> > > --- a/xen/arch/arm/domain.c 
> > > +++ b/xen/arch/arm/domain.c 
> > > @@ -141,6 +141,8 @@ static void ctxt_switch_to(struct vcpu *n) 
> > >      /* VGIC */ 
> > >      gic_restore_state(n); 
> > > +    local_irq_enable(); 
> > > +
> > 
> > Could you move the local_irq_enable right after ctxt_switch_to?
> 
> Of course.
> Just one small concern:
> Would it be more efficient (i.e., less scheduling latency) if we
> enable irq right after gic_restore state similar to lock-breaking
> effect?

Perhaps, but I think at this stage we should aim for obvious
correctness.

Optimising things for IRQ/scheduler latency is a complete project in its
own right.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-05-21 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 11:13 Bug report and patch about IRQ freezing after gic_restore_state 유재용
2013-05-21 13:00 ` Ian Campbell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-05-23 23:57 Jaeyong Yoo
2013-05-22  2:34 Jaeyong Yoo
2013-05-22 16:55 ` Stefano Stabellini
2013-05-23 13:24   ` Ian Campbell
2013-05-20  0:41 Jaeyong Yoo
2013-05-20 13:11 ` Julien Grall
2013-05-21 12:00   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369141209.21246.63.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=jaeyong.yoo@samsung.com \
    --cc=julien.grall@linaro.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.