All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Michal Simek <monstr@monstr.eu>, microblaze-uclinux@itee.uq.edu.au
Subject: [PATCH v3 05/11] microblaze: uaccess s/might_sleep/might_fault/
Date: Fri, 24 May 2013 17:18:07 +0300	[thread overview]
Message-ID: <1369404522-12927-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <cover.1368702323.git.mst@redhat.com>

The only reason uaccess routines might sleep
is if they fault. Make this explicit.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 arch/microblaze/include/asm/uaccess.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/microblaze/include/asm/uaccess.h b/arch/microblaze/include/asm/uaccess.h
index efe59d8..2fc8bf7 100644
--- a/arch/microblaze/include/asm/uaccess.h
+++ b/arch/microblaze/include/asm/uaccess.h
@@ -145,7 +145,7 @@ static inline unsigned long __must_check __clear_user(void __user *to,
 static inline unsigned long __must_check clear_user(void __user *to,
 							unsigned long n)
 {
-	might_sleep();
+	might_fault();
 	if (unlikely(!access_ok(VERIFY_WRITE, to, n)))
 		return n;
 
@@ -371,7 +371,7 @@ extern long __user_bad(void);
 static inline long copy_from_user(void *to,
 		const void __user *from, unsigned long n)
 {
-	might_sleep();
+	might_fault();
 	if (access_ok(VERIFY_READ, from, n))
 		return __copy_from_user(to, from, n);
 	return n;
@@ -385,7 +385,7 @@ static inline long copy_from_user(void *to,
 static inline long copy_to_user(void __user *to,
 		const void *from, unsigned long n)
 {
-	might_sleep();
+	might_fault();
 	if (access_ok(VERIFY_WRITE, to, n))
 		return __copy_to_user(to, from, n);
 	return n;
-- 
MST

  parent reply	other threads:[~2013-05-24 14:17 UTC|newest]

Thread overview: 228+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16 11:07 [PATCH v2 00/10] uaccess: better might_sleep/might_fault behavior Michael S. Tsirkin
2013-05-16 11:07 ` Michael S. Tsirkin
2013-05-16 11:07 ` Michael S. Tsirkin
2013-05-16 11:07 ` Michael S. Tsirkin
2013-05-16 11:07 ` Michael S. Tsirkin
2013-05-16 11:07 ` Michael S. Tsirkin
2013-05-16 11:10 ` [PATCH v2 01/10] asm-generic: uaccess s/might_sleep/might_fault/ Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10 ` [PATCH v2 02/10] arm64: " Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 13:29   ` Catalin Marinas
2013-05-16 13:29     ` Catalin Marinas
2013-05-16 13:29     ` Catalin Marinas
2013-05-16 13:29     ` Catalin Marinas
2013-05-16 13:29     ` Catalin Marinas
2013-05-16 13:29     ` Catalin Marinas
2013-05-16 13:29     ` Catalin Marinas
2013-05-16 11:10 ` [PATCH v2 03/10] frv: " Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:10   ` Michael S. Tsirkin
2013-05-16 11:11 ` [PATCH v2 04/10] m32r: " Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11 ` [PATCH v2 05/10] microblaze: " Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:11   ` Michael S. Tsirkin
2013-05-16 11:12 ` [PATCH v2 06/10] mn10300: " Michael S. Tsirkin
2013-05-16 11:12   ` Michael S. Tsirkin
2013-05-16 11:12   ` Michael S. Tsirkin
2013-05-16 11:12   ` Michael S. Tsirkin
2013-05-16 11:12   ` Michael S. Tsirkin
2013-05-16 11:12   ` Michael S. Tsirkin
2013-05-16 11:15 ` [PATCH v2 07/10] powerpc: " Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-22 13:59   ` Arnd Bergmann
2013-05-22 13:59     ` Arnd Bergmann
2013-05-22 13:59     ` Arnd Bergmann
2013-05-22 13:59     ` Arnd Bergmann
2013-05-22 14:30     ` Michael S. Tsirkin
2013-05-22 14:30       ` Michael S. Tsirkin
2013-05-22 14:30       ` Michael S. Tsirkin
2013-05-22 14:30       ` Michael S. Tsirkin
2013-05-22 14:30       ` Michael S. Tsirkin
2013-05-24 13:00     ` Michael S. Tsirkin
2013-05-24 13:00       ` Michael S. Tsirkin
2013-05-24 13:00       ` Michael S. Tsirkin
2013-05-24 13:00       ` Michael S. Tsirkin
2013-05-24 13:00       ` Michael S. Tsirkin
2013-05-24 13:11       ` Michael S. Tsirkin
2013-05-24 13:11         ` Michael S. Tsirkin
2013-05-24 13:11         ` Michael S. Tsirkin
2013-05-24 13:11         ` Michael S. Tsirkin
2013-05-24 13:11         ` Michael S. Tsirkin
2013-05-24 13:30         ` Arnd Bergmann
2013-05-24 13:30           ` Arnd Bergmann
2013-05-24 13:30           ` Arnd Bergmann
2013-05-24 13:30           ` Arnd Bergmann
2013-05-24 13:30           ` Arnd Bergmann
2013-05-16 11:15 ` [PATCH v2 08/10] tile: " Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 13:33   ` Chris Metcalf
2013-05-16 13:33     ` Chris Metcalf
2013-05-16 13:33     ` Chris Metcalf
2013-05-16 13:33     ` Chris Metcalf
2013-05-16 13:33     ` Chris Metcalf
2013-05-16 13:33     ` Chris Metcalf
2013-05-16 11:15 ` [PATCH v2 09/10] x86: " Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:15   ` Michael S. Tsirkin
2013-05-16 11:16 ` [PATCH v2 10/10] kernel: might_fault does not imply might_sleep Michael S. Tsirkin
2013-05-16 11:16   ` Michael S. Tsirkin
2013-05-16 11:16   ` Michael S. Tsirkin
2013-05-16 11:16   ` Michael S. Tsirkin
2013-05-16 11:16   ` Michael S. Tsirkin
2013-05-16 11:16   ` Michael S. Tsirkin
2013-05-16 18:40   ` Peter Zijlstra
2013-05-16 18:40     ` Peter Zijlstra
2013-05-16 18:40     ` Peter Zijlstra
2013-05-16 18:40     ` Peter Zijlstra
2013-05-16 18:40     ` Peter Zijlstra
2013-05-19  9:35     ` Michael S. Tsirkin
2013-05-19  9:35       ` Michael S. Tsirkin
2013-05-19  9:35       ` Michael S. Tsirkin
2013-05-19  9:35       ` Michael S. Tsirkin
2013-05-19  9:35       ` Michael S. Tsirkin
2013-05-19 12:34       ` Steven Rostedt
2013-05-19 12:34         ` Steven Rostedt
2013-05-19 12:34         ` Steven Rostedt
2013-05-19 12:34         ` Steven Rostedt
2013-05-19 12:34         ` Steven Rostedt
2013-05-19 13:34         ` Michael S. Tsirkin
2013-05-19 13:34           ` Michael S. Tsirkin
2013-05-19 13:34           ` Michael S. Tsirkin
2013-05-19 13:34           ` Michael S. Tsirkin
2013-05-19 13:34           ` Michael S. Tsirkin
2013-05-19 16:06           ` Steven Rostedt
2013-05-19 16:06             ` Steven Rostedt
2013-05-19 16:06             ` Steven Rostedt
2013-05-19 16:06             ` Steven Rostedt
2013-05-19 16:06             ` Steven Rostedt
2013-05-19 16:40             ` Michael S. Tsirkin
2013-05-19 16:40               ` Michael S. Tsirkin
2013-05-19 16:40               ` Michael S. Tsirkin
2013-05-19 16:40               ` Michael S. Tsirkin
2013-05-19 16:40               ` Michael S. Tsirkin
2013-05-19 20:23               ` Steven Rostedt
2013-05-19 20:23                 ` Steven Rostedt
2013-05-19 20:23                 ` Steven Rostedt
2013-05-19 20:23                 ` Steven Rostedt
2013-05-19 20:23                 ` Steven Rostedt
2013-05-19 20:35                 ` Michael S. Tsirkin
2013-05-19 20:35                   ` Michael S. Tsirkin
2013-05-19 20:35                   ` Michael S. Tsirkin
2013-05-19 20:35                   ` Michael S. Tsirkin
2013-05-19 20:35                   ` Michael S. Tsirkin
2013-05-21 11:18               ` Peter Zijlstra
2013-05-21 11:18                 ` Peter Zijlstra
2013-05-21 11:18                 ` Peter Zijlstra
2013-05-21 11:18                 ` Peter Zijlstra
2013-05-21 11:21       ` Peter Zijlstra
2013-05-21 11:21         ` Peter Zijlstra
2013-05-21 11:21         ` Peter Zijlstra
2013-05-21 11:21         ` Peter Zijlstra
2013-05-21 11:57       ` Peter Zijlstra
2013-05-21 11:57         ` Peter Zijlstra
2013-05-21 11:57         ` Peter Zijlstra
2013-05-21 11:57         ` Peter Zijlstra
2013-05-21 13:28         ` Michael S. Tsirkin
2013-05-21 13:28           ` Michael S. Tsirkin
2013-05-22  9:47         ` Michael S. Tsirkin
2013-05-22  9:47           ` Michael S. Tsirkin
2013-05-22  9:47           ` Michael S. Tsirkin
2013-05-22  9:47           ` Michael S. Tsirkin
2013-05-22  9:47           ` Michael S. Tsirkin
2013-05-22 10:16           ` Peter Zijlstra
2013-05-22 10:16             ` Peter Zijlstra
2013-05-22 10:16             ` Peter Zijlstra
2013-05-22 10:16             ` Peter Zijlstra
2013-05-22 20:38         ` Michael S. Tsirkin
2013-05-22 20:38           ` Michael S. Tsirkin
2013-05-22 20:38           ` Michael S. Tsirkin
2013-05-22 20:38           ` Michael S. Tsirkin
2013-05-22 20:38           ` Michael S. Tsirkin
2013-05-22 20:36     ` Michael S. Tsirkin
2013-05-22 20:36       ` Michael S. Tsirkin
2013-05-22 20:36       ` Michael S. Tsirkin
2013-05-22 20:36       ` Michael S. Tsirkin
2013-05-22 20:36       ` Michael S. Tsirkin
2013-05-22  9:25 ` [PATCH v2 00/10] uaccess: better might_sleep/might_fault behavior Arnd Bergmann
2013-05-22  9:25   ` Arnd Bergmann
2013-05-22  9:25   ` Arnd Bergmann
2013-05-22  9:25   ` Arnd Bergmann
2013-05-22  9:58   ` Michael S. Tsirkin
2013-05-22  9:58     ` Michael S. Tsirkin
2013-05-22  9:58     ` Michael S. Tsirkin
2013-05-22  9:58     ` Michael S. Tsirkin
2013-05-22  9:58     ` Michael S. Tsirkin
2013-05-22 10:19   ` Peter Zijlstra
2013-05-22 10:19     ` Peter Zijlstra
2013-05-22 10:19     ` Peter Zijlstra
2013-05-22 10:19     ` Peter Zijlstra
2013-05-22 11:07     ` Michael S. Tsirkin
2013-05-22 11:07       ` Michael S. Tsirkin
2013-05-22 11:07       ` Michael S. Tsirkin
2013-05-22 11:07       ` Michael S. Tsirkin
2013-05-22 11:07       ` Michael S. Tsirkin
2013-05-22 11:27       ` Peter Zijlstra
2013-05-22 11:27         ` Peter Zijlstra
2013-05-22 11:27         ` Peter Zijlstra
2013-05-22 11:27         ` Peter Zijlstra
2013-05-22 11:27         ` Peter Zijlstra
2013-05-22 13:41   ` Russell King - ARM Linux
2013-05-22 13:41     ` Russell King - ARM Linux
2013-05-22 13:41     ` Russell King - ARM Linux
2013-05-22 13:41     ` Russell King - ARM Linux
2013-05-22 14:04     ` Arnd Bergmann
2013-05-22 14:04       ` Arnd Bergmann
2013-05-22 14:04       ` Arnd Bergmann
2013-05-22 14:04       ` Arnd Bergmann
2013-05-22 14:44       ` Michael S. Tsirkin
2013-05-22 14:44         ` Michael S. Tsirkin
2013-05-22 14:44         ` Michael S. Tsirkin
2013-05-22 14:44         ` Michael S. Tsirkin
2013-05-22 14:44         ` Michael S. Tsirkin
2013-05-22 14:44         ` Michael S. Tsirkin
2013-05-24 14:17 ` [PATCH v3 01/11] asm-generic: uaccess s/might_sleep/might_fault/ Michael S. Tsirkin
2013-05-24 14:17 ` [PATCH v3 02/11] arm64: " Michael S. Tsirkin
2013-05-24 14:17   ` Michael S. Tsirkin
2013-05-24 14:17 ` [PATCH v3 03/11] frv: " Michael S. Tsirkin
2013-05-24 14:18 ` [PATCH v3 04/11] m32r: " Michael S. Tsirkin
2013-05-24 14:18 ` Michael S. Tsirkin [this message]
2013-05-24 14:18 ` [PATCH v3 06/11] mn10300: " Michael S. Tsirkin
2013-05-24 14:18 ` [PATCH v3 07/11] powerpc: " Michael S. Tsirkin
2013-05-24 14:18   ` Michael S. Tsirkin
2013-05-24 14:18 ` [PATCH v3 08/11] tile: " Michael S. Tsirkin
2013-05-24 14:18 ` [PATCH v3 09/11] x86: " Michael S. Tsirkin
2013-05-24 14:18 ` [PATCH v3 10/11] kernel: drop voluntary schedule from might_fault Michael S. Tsirkin
2013-05-24 14:18   ` Michael S. Tsirkin
2013-05-24 14:18 ` [PATCH v3 11/11] kernel: uaccess in atomic with pagefault_disable Michael S. Tsirkin
2013-05-24 14:18   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369404522-12927-5-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=monstr@monstr.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.