All of lore.kernel.org
 help / color / mirror / Atom feed
From: atomlin@redhat.com
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, pshelar@nicira.com,
	mst@redhat.com, alexander.h.duyck@intel.com, riel@redhat.com,
	aquini@redhat.com, sergei.shtylyov@cogentembedded.com,
	linux-kernel@vger.kernel.org, Aaron Tomlin <atomlin@redhat.com>
Subject: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets
Date: Sun, 26 May 2013 21:45:01 +0100	[thread overview]
Message-ID: <1369601101-23057-1-git-send-email-atomlin@redhat.com> (raw)

From: Aaron Tomlin <atomlin@redhat.com>

Since v1:
 - Removed unnecessary parentheses (sergei.shtylyov)

---8<---

Failed GFP_ATOMIC allocations by the network stack result in dropped
packets, which will be received on a subsequent retransmit, and an
unnecessary, noisy warning with a kernel backtrace.

These warnings are harmless, but they still cause users to panic and
file bug reports over dropped packets. It would be better to hide the
failed allocation warnings and backtraces, and let retransmits handle
dropped packets quietly.

Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
---
 net/core/skbuff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index af9185d..84aa870 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -236,7 +236,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
 		? skbuff_fclone_cache : skbuff_head_cache;
 
 	if (sk_memalloc_socks() && (flags & SKB_ALLOC_RX))
-		gfp_mask |= __GFP_MEMALLOC;
+		gfp_mask |= __GFP_MEMALLOC | __GFP_NOWARN;
 
 	/* Get the HEAD */
 	skb = kmem_cache_alloc_node(cache, gfp_mask & ~__GFP_DMA, node);
-- 
1.8.1.4


             reply	other threads:[~2013-05-26 20:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-26 20:45 atomlin [this message]
2013-05-27 18:18 ` [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets Rafael Aquini
2013-05-27 22:41 ` Francois Romieu
2013-05-28 16:00   ` Ben Greear
2013-05-28 16:15     ` Rafael Aquini
2013-05-28 16:19       ` Ben Greear
2013-05-28 16:29       ` Eric Dumazet
2013-05-28 17:43         ` Rafael Aquini
2013-05-28 17:46           ` Eric Dumazet
2013-05-28 18:03           ` Eric Dumazet
2013-05-28 18:19         ` Joe Perches
2013-05-28 21:32         ` Rik van Riel
2013-05-28 17:29     ` Joe Perches
2013-05-28 21:30   ` Rik van Riel
  -- strict thread matches above, loose matches on Subject: below --
2013-05-26 20:19 atomlin
2013-05-27 17:39 ` Rik van Riel
2013-05-27 22:25   ` Eric Dumazet
2013-05-28  4:31     ` Joe Perches
2013-05-28  6:04       ` Eric Dumazet
2013-05-28  6:08         ` Joe Perches
2013-05-28 17:15       ` Debabrata Banerjee
2013-05-29  7:36     ` Rik van Riel
2013-05-27 17:56 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369601101-23057-1-git-send-email-atomlin@redhat.com \
    --to=atomlin@redhat.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=aquini@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=riel@redhat.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.