All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: backports@vger.kernel.org
Subject: Re: [PATCH] backports: catch make in backport template directory
Date: Tue, 28 May 2013 23:34:34 +0200	[thread overview]
Message-ID: <1369776874.8548.31.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <51A51E0E.8010803@lwfinger.net> (sfid-20130528_231354_988207_BF6CF854)

On Tue, 2013-05-28 at 16:13 -0500, Larry Finger wrote:
> On 05/28/2013 03:33 PM, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Catch running make in the backport template directory by
> > checking for the .local-symbols file. If it isn't there
> > then we're in the input/template directory rather than in
> > an output tree, give the user a hint about it instead of
> > keeling over.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
> >   backport/Makefile | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/backport/Makefile b/backport/Makefile
> > index 287b27d..f0c7586 100644
> > --- a/backport/Makefile
> > +++ b/backport/Makefile
> > @@ -37,6 +37,18 @@ mrproper:
> >   	@rm -f backport-include/backport/autoconf.h
> >
> >   .DEFAULT:
> > +	@set -e ; test -f .local-symbols || (						\
> > +	echo "/--------------"								;\
> > +	echo "| You shouldn't run make in the backports tree, but only in"		;\
> > +	echo "| the generated output. This here is only the skeleton code"		;\
> > +	echo "| copied into the output directory. To use the backport system"		;\
> > +	echo "| from scratch, go into the top-level directoroy and run"			;\
> 
> =======================================================^ Typo here.

Good catch, thanks. Luis, can you just fix that when you apply or do you
want a resend?

johannes


  reply	other threads:[~2013-05-28 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 20:33 [PATCH] backports: catch make in backport template directory Johannes Berg
2013-05-28 21:13 ` Larry Finger
2013-05-28 21:34   ` Johannes Berg [this message]
2013-05-28 22:10     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369776874.8548.31.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=backports@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.