From: Mattia Dongili <malattia@linux.it>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: platform-driver-x86@vger.kernel.org,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Mattia Dongili <malattia@linux.it>
Subject: [PATCH 1/2] Fix to return a negative error code in the sonypi_compat_init()
Date: Wed, 29 May 2013 06:55:32 +0900 [thread overview]
Message-ID: <1369778133-24015-2-git-send-email-malattia@linux.it> (raw)
In-Reply-To: <1369778133-24015-1-git-send-email-malattia@linux.it>
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Return -1 in the error handling case instead of 0, as done elsewhere in
this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mattia Dongili <malattia@linux.it>
---
drivers/platform/x86/sony-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 2ac045f..b162733 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -4320,7 +4320,8 @@ static int sony_pic_add(struct acpi_device *device)
goto err_free_resources;
}
- if (sonypi_compat_init())
+ result = sonypi_compat_init();
+ if (result)
goto err_remove_input;
/* request io port */
--
1.7.10.4
next prev parent reply other threads:[~2013-05-28 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 21:55 [PATCH 0/2] sony-laptop fixes for 3.10 Mattia Dongili
2013-05-28 21:55 ` Mattia Dongili [this message]
2013-05-28 21:55 ` [PATCH 2/2] Fix reporting of sony-laptop gfx_switch_status Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369778133-24015-2-git-send-email-malattia@linux.it \
--to=malattia@linux.it \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.