From: Artem Bityutskiy <dedekind1@gmail.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH RESEND] mtd: denali: fix error handling for devm_ioremap_nocache()
Date: Wed, 29 May 2013 15:42:49 +0300 [thread overview]
Message-ID: <1369831369.24286.26.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1367555839-12920-1-git-send-email-xi.wang@gmail.com>
On Fri, 2013-05-03 at 00:37 -0400, Xi Wang wrote:
> It is incorrect to use `!res' for error handling since `res' must be
> non-null. Use the return value `ptr' instead.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> ---
This is already fixed upstream:
commit 6c67050ab108bcce2576fa1d7a0557eb0376520a
Author: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon Mar 18 15:11:11 2013 +0530
mtd: denali_dt: Fix incorrect error check
The return value of devm_ioremap_nocache should be checked here
instead
of res.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2013-05-29 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 4:37 [PATCH RESEND] mtd: denali: fix error handling for devm_ioremap_nocache() Xi Wang
2013-05-29 12:42 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369831369.24286.26.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.