All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [ring_buffer_entries] BUG: unable to handle kernel NULL pointer dereference at   (null)
Date: Wed, 29 May 2013 15:36:24 -0400	[thread overview]
Message-ID: <1369856184.15552.76.camel@gandalf.local.home> (raw)
In-Reply-To: <20130529141333.GA24064@localhost>

On Wed, 2013-05-29 at 22:13 +0800, Fengguang Wu wrote:
> Hi Rostedt,
> 
> I got the below BUG and the first bad commit could be any of:
> 
> ce9bae55972b228cf7bac34350c4d2caf8ea0d0b
> 121aaee7b0a82605d33af200c7e9ebab6fd6e444
> 737223fbca3b1c91feb947c7f571b35749b743b6
> 45ad21ca5530efdca6a19e4a5ac5e7bd6e24f996
> a695cb5816228f86576f5f5c6809fdf8ed382ece
> 6de58e6269cd0568ca5fbae14423914eff0f7811
> ad909e21bbe69f1d39055d346540abd827190eca
> 0b85ffc293044393623059eda9904a7d5b644e36
> f5eb5588262cab7232ed1d77cf612b327db50767
> f1affcaaa861f27752a769f889bf1486ebd301fe
> f4e781c0a89d5810729772290441ac7d61f321ec
> 12883efb670c28dff57dcd7f4f995a1ffe153b2d
> 55034cd6e648155393b0d665eef76b38d49ad6bf
> 153e8ed913b022d2003866a848af9fadc041403f
> 
> We cannot bisect more due to broken builds.

No need to bisect. The bug is pretty obvious:

$ grep trace_test_buffer kernel/trace/trace_selftest.c
static int trace_test_buffer_cpu(struct trace_buffer *buf, int cpu)
static int trace_test_buffer(struct trace_buffer *buf, unsigned long
*count)
         * The trace_test_buffer_cpu runs a while loop to consume all
data.
                ret = trace_test_buffer_cpu(buf, cpu);
        ret = trace_test_buffer(&tr->trace_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, NULL);
                ret = trace_test_buffer(&tr->max_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, NULL);
                ret = trace_test_buffer(&tr->max_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, NULL);
        ret = trace_test_buffer(&tr->max_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, NULL);
        ret = trace_test_buffer(&tr->max_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, NULL);
                ret = trace_test_buffer(&tr->max_buffer, &count);
        ret = trace_test_buffer(&tr->trace_buffer, &count);
        ret = trace_test_buffer(tr, &count);


Notice that all but the last one passes in &tr->trace_buffer or
&tr->max_buffer. That last one happens to be in:
trace_selftest_startup_branch()

Thanks!

-- Steve



      reply	other threads:[~2013-05-29 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 14:13 [ring_buffer_entries] BUG: unable to handle kernel NULL pointer dereference at (null) Fengguang Wu
2013-05-29 19:36 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369856184.15552.76.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.