All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jacob Minshall <jacob@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH] mac80211: mesh formation info properly set
Date: Wed, 29 May 2013 21:52:09 +0200	[thread overview]
Message-ID: <1369857129.12820.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1369855313-25871-1-git-send-email-jacob@cozybit.com> (sfid-20130529_212202_758720_0E1A739C)

On Wed, 2013-05-29 at 12:21 -0700, Jacob Minshall wrote:
> Max peerings capped at 63 in accordance with IEEE-2012 8.4.2.100.7,
> and trigger a beacon regeneration every time the number of peerings
> changes. 

Can you write full sentences? Maybe also in the subject ("set mesh ...
properly"?) :-)


> -	neighbors = (neighbors > 15) ? 15 : neighbors;
> +	neighbors = (neighbors > IEEE80211_MAX_MESH_PEERINGS) ?
> +			IEEE80211_MAX_MESH_PEERINGS : neighbors;

min() or min_t()?

>  	atomic_inc(&sdata->u.mesh.estab_plinks);
> -	return mesh_accept_plinks_update(sdata);
> +	mesh_accept_plinks_update(sdata);
> +	return BSS_CHANGED_BEACON;

These changes seem odd to me, why doesn't mesh_accept_plinks_update()
just return the change value then?

johannes


  reply	other threads:[~2013-05-29 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 19:21 [PATCH] mac80211: mesh formation info properly set Jacob Minshall
2013-05-29 19:52 ` Johannes Berg [this message]
2013-05-29 19:53   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369857129.12820.5.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=devel@lists.open80211s.org \
    --cc=jacob@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.