Re: [Xen-users] FreeBSD PVHVM call for testing

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2013-05-29 at 14:24 -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, May 29, 2013 at 06:25:56PM +0100, Ian Campbell wrote:
> > (dropping the BSD lists & xen-users, adding Konrad)
> > 
> > On Wed, 2013-05-29 at 19:03 +0200, Roger Pau Monné wrote:
> > > Thanks Matt and Colin for the testing and help! I've pushed yet another
> > > version, now it's branch pvhvm_v12, which I *think* should solve the
> > > issues with cpuid != acpi_id:
> > > 
> > > http://xenbits.xen.org/gitweb/?p=people/royger/freebsd.git;a=shortlog;h=refs/heads/pvhvm_v12
> > > 
> > > Since I'm not able to reproduce the cpuid != acpi_id case, could you
> > > give it a try and report the results?
> > 
> > Konrad,
> > 
> > Might this same problem be related to the issue you saw doing PVHVM VCPU
> > hotplug which you mentioned the other day?
> 
> This was http://article.gmane.org/gmane.comp.emulators.xen.devel/159105
> 
> > 
> > In general for HVM I suppose there isn't a strict relationship between
> > the CPU number the kernel chooses for a CPU (which is somewhat
> > arbitrarily up to the kernel) and the hypervisors VCPU number (which is
> > exposed via the virtual APIC ID).
> 
> Right. To troubleshoot this I added some instrumentation to make sure
> that the xen_vcpuop_set_mode function was using the right vCPU number.
> 
> Initially it got it from smp_processor_id(), which gets it from the
> APIC ID (at least that is what it looks like). But perhaps it was not.

Is smp_processor_id() always from APIC ID? For x86 I see:
        raw_smp_processor_id()
        stack_smp_processor_id()
        safe_smp_processor_id()
        smp_processor_id()
        logical_smp_processor_id()
        hard_smp_processor_id()
also things like cpu_physical_id(). I'd have to assume they aren't all
equivalent ;-)

> I can't seem to reproduce the issue anymore :-(

Well, that sounds like a good thing to me ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel