All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Shin <jacob.shin@amd.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, <x86@kernel.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Andreas Herrmann <herrmann.der.user@googlemail.com>,
	Borislav Petkov <bp@alien8.de>, Joe Perches <joe@perches.com>,
	<linux-kernel@vger.kernel.org>, Jacob Shin <jacob.shin@amd.com>
Subject: [PATCH V3 2/4] x86/microcode: vendor abstract out save_microcode_in_initrd()
Date: Thu, 30 May 2013 14:09:17 -0500	[thread overview]
Message-ID: <1369940959-2077-3-git-send-email-jacob.shin@amd.com> (raw)
In-Reply-To: <1369940959-2077-1-git-send-email-jacob.shin@amd.com>

Currently save_microcode_in_initrd() is declared in vendor neutural
microcode.h file, but defined in vendor specific
microcode_intel_early.c file. Vendor abstract it out to
microcode_core_early.c with a wrapper function.

Signed-off-by: Jacob Shin <jacob.shin@amd.com>
---
 arch/x86/include/asm/microcode_intel.h  |    2 ++
 arch/x86/kernel/microcode_core_early.c  |   10 ++++++++++
 arch/x86/kernel/microcode_intel_early.c |    2 +-
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/microcode_intel.h b/arch/x86/include/asm/microcode_intel.h
index 5356f92..87a0853 100644
--- a/arch/x86/include/asm/microcode_intel.h
+++ b/arch/x86/include/asm/microcode_intel.h
@@ -67,10 +67,12 @@ update_match_revision(struct microcode_header_intel *mc_header, int rev);
 extern void __init load_ucode_intel_bsp(void);
 extern void __cpuinit load_ucode_intel_ap(void);
 extern void show_ucode_info_early(void);
+extern int __init save_microcode_in_initrd_intel(void);
 #else
 static inline __init void load_ucode_intel_bsp(void) {}
 static inline __cpuinit void load_ucode_intel_ap(void) {}
 static inline void show_ucode_info_early(void) {}
+static inline int __init save_microcode_in_initrd_intel(void) { return -EINVAL; }
 #endif
 
 #if defined(CONFIG_MICROCODE_INTEL_EARLY) && defined(CONFIG_HOTPLUG_CPU)
diff --git a/arch/x86/kernel/microcode_core_early.c b/arch/x86/kernel/microcode_core_early.c
index 833d51d..0d19ac5 100644
--- a/arch/x86/kernel/microcode_core_early.c
+++ b/arch/x86/kernel/microcode_core_early.c
@@ -98,3 +98,13 @@ void __cpuinit load_ucode_ap(void)
 	if (vendor == X86_VENDOR_INTEL && x86 >= 6)
 		load_ucode_intel_ap();
 }
+
+int __init save_microcode_in_initrd(void)
+{
+	struct cpuinfo_x86 *c = &boot_cpu_data;
+
+	if (c->x86_vendor == X86_VENDOR_INTEL && c->x86 >= 6)
+		return save_microcode_in_initrd_intel();
+
+	return 0;
+}
diff --git a/arch/x86/kernel/microcode_intel_early.c b/arch/x86/kernel/microcode_intel_early.c
index a07f0a0..dabef95 100644
--- a/arch/x86/kernel/microcode_intel_early.c
+++ b/arch/x86/kernel/microcode_intel_early.c
@@ -699,7 +699,7 @@ static int __cpuinit apply_microcode_early(struct mc_saved_data *mc_saved_data,
  * This function converts microcode patch offsets previously stored in
  * mc_saved_in_initrd to pointers and stores the pointers in mc_saved_data.
  */
-int __init save_microcode_in_initrd(void)
+int __init save_microcode_in_initrd_intel(void)
 {
 	unsigned int count = mc_saved_data.mc_saved_count;
 	struct microcode_intel *mc_saved[MAX_UCODE_COUNT];
-- 
1.7.9.5



  parent reply	other threads:[~2013-05-30 19:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 19:09 [PATCH V3 0/4] x86/microcode: early microcode patch loading support on AMD Jacob Shin
2013-05-30 19:09 ` [PATCH V3 1/4] x86, microcode, intel: Correct typo in printk Jacob Shin
2013-05-31  3:26   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2013-05-30 19:09 ` Jacob Shin [this message]
2013-05-31  3:27   ` [tip:x86/microcode] x86, microcode: Vendor abstract out save_microcode_in_initrd() tip-bot for Jacob Shin
2013-05-30 19:09 ` [PATCH V3 3/4] x86/microcode/amd: refactor functions to prepare for early loading Jacob Shin
2013-05-31  3:29   ` [tip:x86/microcode] x86, microcode, amd: Refactor " tip-bot for Jacob Shin
2013-05-30 19:09 ` [PATCH V3 4/4] microcode/x86/amd: early microcode patch loading support for AMD Jacob Shin
2013-05-31  3:31   ` [tip:x86/microcode] x86, microcode, amd: Early " tip-bot for Jacob Shin
2013-05-31  6:10     ` Yinghai Lu
2013-05-31  6:59       ` Jacob Shin
2013-05-31  8:41     ` Borislav Petkov
2013-05-31 15:02       ` Jacob Shin
2013-05-31 15:13         ` H. Peter Anvin
2013-05-31 15:17           ` Jacob Shin
2013-05-31 21:59         ` [tip:x86/microcode] x86, microcode, amd: Fix warnings and errors on with CONFIG_MICROCODE=m tip-bot for Jacob Shin
2013-06-01  9:30           ` Borislav Petkov
2013-06-04 21:02           ` Yinghai Lu
2013-06-04 21:36             ` Jacob Shin
2013-06-04 21:55               ` Jacob Shin
2013-06-04 22:05                 ` Yinghai Lu
2013-05-31  4:26   ` [PATCH V3 4/4] microcode/x86/amd: early microcode patch loading support for AMD Henrique de Moraes Holschuh
2013-05-31 15:54     ` Jacob Shin
2013-05-31 19:32     ` Andreas Herrmann
2013-05-31 21:30       ` Henrique de Moraes Holschuh
2013-06-01  1:15         ` Jacob Shin
2013-06-05 22:10           ` Borislav Petkov
2013-06-06 20:06             ` Jacob Shin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369940959-2077-3-git-send-email-jacob.shin@amd.com \
    --to=jacob.shin@amd.com \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=herrmann.der.user@googlemail.com \
    --cc=hpa@zytor.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.