From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932531AbdJaQ5E (ORCPT ); Tue, 31 Oct 2017 12:57:04 -0400 Received: from mout.web.de ([212.227.15.3]:51641 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbdJaQ4v (ORCPT ); Tue, 31 Oct 2017 12:56:51 -0400 Subject: Re: Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() To: Andy Shevchenko , platform-driver-x86@vger.kernel.org Cc: Andy Shevchenko , Darren Hart , Mattia Dongili , LKML , kernel-janitors@vger.kernel.org References: From: SF Markus Elfring Message-ID: <136e2b05-a601-f8de-dd84-d72b765ea4df@users.sourceforge.net> Date: Tue, 31 Oct 2017 17:56:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:VJ7lQ4xzwELYvxBTvDCmUgTsNXrGUaS1iLFQleYX2JN9zeqDa+y MTfatwUygyfGeORW/JW7MZld8k0IQbq+vV0BoelREcCG4+shoGzM4amGUDL9zGR5BJv3qve xA+23opnq+mYAXJI16Oorv5+XDE6cFNF3jU8f5QBngsFauT0K9qeuAHxWrMO347eViciJUc c1F3eDp8tqbdwNyJMLH5Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:fO/aTvpRSDw=:GgK+DuzqsBA2EFpjCdUXLU CH5kc81YbRp2rh6/W5GfaGTbxrhQtWDu9LSINeU19TXxPsyKvM7TuOY3Y/ohiZO4rOYHRG9Bz M9cb5jwXagmNTcXzzTtcDmP+6XOVm90cv4J5hQRD1I/KAomWEwapXzk4ncMx4gaoirF7Dj7K/ zY7OrV3s+GI1D7NNR2VKvjniDIWo76TTQFWeBvktUjFVESTuD03KAGc1zRnCCHN1pg/LCkibG 3YSoAqzEHrG1wLjiPSU9LFGi0juEdr1O4uO5Kam6swZLtbQlHFVFT158LvhyRWYmymX6mphEW v3IvZ62UnvEvoUp1vFQKpo/kNO/lQUWXRm+T2K0a0D8k9WmozS7+7AVZY4YBZN0gAryCaliZJ QCD5myn6qTJGbO3RzDGIS2PX6/zHIYx6lxS6XURw/XNAHo0WM4bv3LeCV1loPStHNrsNBhnfO desFrql/gmKw+oDcqOMwkz3Ts3gq9zX3CZvhxvBudh+fAjxXk/C5nsZcD8OhIoazI+y8+BkPd MP0Gwo9EXlbGNhm4K9E+kP1CLhJ3YjMm50lp2EVYgBq3JCN4lqi7pNAk6/HI9AW7Y7/xnF+Xw AYIEgEkzRfRBxMw0jCEr3Q/nuliAXliBYlfKV7LGhsjk80vw86vFg9RxC8Q/xKRYmy0t8QIO9 YQY2Hx0jN7Geck+ua/U15BjbBbrYCWfb0e78S4zbVCSTScjC4KYlKRjfWuvRwJaYjiYK6ohL4 sUJGr5AzyocF08jKiFbZ09sCIkB0DET4Zco8QNehjosCU/u6Gw7aIPI8p6/UaDwB3GJHKxah5 k8JEpEStsaxWPq3HzLYOS83kuCV/TMnUuhSWK9S+i52lJJDjUQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I performed another simple software refactoring. > > Which is _useless_ per se I disagree in this case because the goal of a refactoring should be to adjust something in a desired direction without changing the provided functionality. > by the reasons you had been told already _several_ times about. There can be other reasons why you do not like a concrete change. > Either you do a real fix (propagate correct error codes > to upper layers), or just don't bother at all. Have the involved contributors any preferences on organisation of corresponding update steps? * Correct exception handling first and then apply the shown source code reduction again. * Combine better exception handling with smaller code in one patch. * Addition of the tag “Fixes” in the commit message? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 31 Oct 2017 16:56:21 +0000 Subject: Re: Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() Message-Id: <136e2b05-a601-f8de-dd84-d72b765ea4df@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Andy Shevchenko , platform-driver-x86@vger.kernel.org Cc: Andy Shevchenko , Darren Hart , Mattia Dongili , LKML , kernel-janitors@vger.kernel.org >> I performed another simple software refactoring. > > Which is _useless_ per se I disagree in this case because the goal of a refactoring should be to adjust something in a desired direction without changing the provided functionality. > by the reasons you had been told already _several_ times about. There can be other reasons why you do not like a concrete change. > Either you do a real fix (propagate correct error codes > to upper layers), or just don't bother at all. Have the involved contributors any preferences on organisation of corresponding update steps? * Correct exception handling first and then apply the shown source code reduction again. * Combine better exception handling with smaller code in one patch. * Addition of the tag “Fixes” in the commit message? Regards, Markus