From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756142Ab3FEQI5 (ORCPT ); Wed, 5 Jun 2013 12:08:57 -0400 Received: from mail-bl2lp0212.outbound.protection.outlook.com ([207.46.163.212]:11912 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755655Ab3FEQI4 (ORCPT ); Wed, 5 Jun 2013 12:08:56 -0400 From: Matthew Garrett To: Matt Fleming CC: "Fleming, Matt" , joeyli , "rja@sgi.com" , "mingo@kernel.org" , "torvalds@linux-foundation.org" , "bp@alien8.de" , "jkosina@suse.cz" , "linux-efi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "hpa@linux.intel.com" , "akpm@linux-foundation.org" , "oneukum@suse.de" Subject: Re: [PATCH] Modify UEFI anti-bricking code Thread-Topic: [PATCH] Modify UEFI anti-bricking code Thread-Index: AQHOXwRQ69J870D+8ESfIa4gHR89tpkkLJYAgAAE7oCAALmWgIACTrOAgAABCYCAABJVAIAAAq6A Date: Wed, 5 Jun 2013 16:08:39 +0000 Message-ID: <1370448519.6315.36.camel@x230.lan> References: <1370117180-1712-1-git-send-email-matthew.garrett@nebula.com> <1370276021.30695.4.camel@linux-s257.site> <1370277079.6315.14.camel@x230.lan> <1370316933.30695.7.camel@linux-s257.site> <1370444007.6315.32.camel@x230.lan> <20130605155904.GC30420@console-pimps.org> In-Reply-To: <20130605155904.GC30420@console-pimps.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.4] x-forefront-antispam-report: SFV:SKI;SFS:;DIR:OUT;SFP:;SCL:-1;SRVR:BY2PR05MB222;H:BY2PR05MB222.namprd05.prod.outlook.com;LANG:en; Content-Type: text/plain; charset="utf-8" Content-ID: <2DCA9AAFD6F52F41AA2F8C296796801F@namprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r55G963L001403 On Wed, 2013-06-05 at 16:59 +0100, Matt Fleming wrote: > + /* clean DUMMY object */ > + efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID, 0, 0, NULL); Hm. Actually, is that going to work? From the spec: If a preexisting variable is rewritten with different attributes, SetVariable()shall not modify the variable and shall return EFI_INVALID_PARAMETER. So I think we probably need to fix the attributes to NV|RT|BS for both this call and the one in query_variable_store. We should probably also only do the workaround if the NV bit is set in the original query. -- Matthew Garrett | mjg59@srcf.ucam.org {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] Modify UEFI anti-bricking code Date: Wed, 5 Jun 2013 16:08:39 +0000 Message-ID: <1370448519.6315.36.camel@x230.lan> References: <1370117180-1712-1-git-send-email-matthew.garrett@nebula.com> <1370276021.30695.4.camel@linux-s257.site> <1370277079.6315.14.camel@x230.lan> <1370316933.30695.7.camel@linux-s257.site> <1370444007.6315.32.camel@x230.lan> <20130605155904.GC30420@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20130605155904.GC30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> Content-Language: en-US Content-ID: <2DCA9AAFD6F52F41AA2F8C296796801F-HX+pjaQZbrqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: "Fleming, Matt" , joeyli , "rja-sJ/iWh9BUns@public.gmane.org" , "mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org" , "jkosina-AlSwsSmVLrQ@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org" , "hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "oneukum-l3A5Bk7waGM@public.gmane.org" List-Id: linux-efi@vger.kernel.org T24gV2VkLCAyMDEzLTA2LTA1IGF0IDE2OjU5ICswMTAwLCBNYXR0IEZsZW1pbmcgd3JvdGU6DQoN Cj4gKwkvKiBjbGVhbiBEVU1NWSBvYmplY3QgKi8NCj4gKwllZmkuc2V0X3ZhcmlhYmxlKGVmaV9k dW1teV9uYW1lLCAmRUZJX0RVTU1ZX0dVSUQsIDAsIDAsIE5VTEwpOw0KDQpIbS4gQWN0dWFsbHks IGlzIHRoYXQgZ29pbmcgdG8gd29yaz8gRnJvbSB0aGUgc3BlYzoNCg0KSWYgYSBwcmVleGlzdGlu ZyB2YXJpYWJsZSBpcyByZXdyaXR0ZW4gd2l0aCBkaWZmZXJlbnQgYXR0cmlidXRlcywNClNldFZh cmlhYmxlKClzaGFsbCBub3QgbW9kaWZ5IHRoZSB2YXJpYWJsZSBhbmQgc2hhbGwgcmV0dXJuDQpF RklfSU5WQUxJRF9QQVJBTUVURVIuIA0KDQpTbyBJIHRoaW5rIHdlIHByb2JhYmx5IG5lZWQgdG8g Zml4IHRoZSBhdHRyaWJ1dGVzIHRvIE5WfFJUfEJTIGZvciBib3RoDQp0aGlzIGNhbGwgYW5kIHRo ZSBvbmUgaW4gcXVlcnlfdmFyaWFibGVfc3RvcmUuIFdlIHNob3VsZCBwcm9iYWJseSBhbHNvDQpv bmx5IGRvIHRoZSB3b3JrYXJvdW5kIGlmIHRoZSBOViBiaXQgaXMgc2V0IGluIHRoZSBvcmlnaW5h bCBxdWVyeS4NCg0KLS0gDQpNYXR0aGV3IEdhcnJldHQgfCBtamc1OUBzcmNmLnVjYW0ub3JnDQo=