From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] tools/misc/xencov.c: Use MAP_WIRED on NetBSD
Date: Wed, 12 Jun 2013 14:16:12 +0100
Message-ID: <1371042972.24512.428.camel@zakaz.uk.xensource.com>
References: <51A74A37.5070502@amazon.de>
	<1369999519.5199.99.camel@zakaz.uk.xensource.com>
	<1370958416.1654.3.camel@hamster.uk.xensource.com>
	<1371028899.24512.376.camel@zakaz.uk.xensource.com>
	<1371038547.26497.4.camel@hamster.uk.xensource.com>
	<1371039293.24512.425.camel@zakaz.uk.xensource.com>
	<51B873DE.5030109@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51B873DE.5030109@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Frediano Ziglio <frediano.ziglio@citrix.com>, Christoph Egger <chegger@amazon.de>, Frediano Ziglio <frediano.ziglio@citrite.net>, Miguel Clara <miguelmclara@gmail.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2013-06-12 at 14:13 +0100, George Dunlap wrote:
> On 12/06/13 13:14, Ian Campbell wrote:
> > On Wed, 2013-06-12 at 13:02 +0100, Frediano Ziglio wrote:
> >> Subject: [PATCH] gcov: Do not use mmap directly but use xc_hypercall_buffer_alloc
> >>
> >> xencov.c did not compile on NetBSD so use xc_hypercall_buffer which is
> >> more portable.
> >>
> >> Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
> > Looks good to me, thanks,
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > George, what is your feeling for the release? This is a somewhat obscure
> > tool and IMHO the risk of regressing is small. The change fixes the
> > default build on NetBSD.
> 
> Did we even have gcov in 4.2?

Good point, no we didn't.

>   Anyway I agree, the benefits are worth 
> more than the risk.
> 
> Re the release:
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> 
>   -George
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel