From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnBZB-0003dm-5f for qemu-devel@nongnu.org; Thu, 13 Jun 2013 13:44:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnBZ7-0005gz-4K for qemu-devel@nongnu.org; Thu, 13 Jun 2013 13:44:09 -0400 Received: from smtp.eu.citrix.com ([46.33.159.39]:27783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnBZ6-0005fp-Ux for qemu-devel@nongnu.org; Thu, 13 Jun 2013 13:44:05 -0400 Message-ID: <1371145442.6955.64.camel@zakaz.uk.xensource.com> From: Ian Campbell Date: Thu, 13 Jun 2013 18:44:02 +0100 In-Reply-To: References: <1371117054-5694-1-git-send-email-paul.durrant@citrix.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Paul Durrant , qemu-devel@nongnu.org, xen-devel@lists.xen.org On Thu, 2013-06-13 at 18:33 +0100, Stefano Stabellini wrote: > On Thu, 13 Jun 2013, Paul Durrant wrote: > > The xen-platform device should be initialized by the Xen toolstack by > > passing the appropriate -device argument on the command line. > > > > Signed-off-by: Paul Durrant > > This patch is problematic because we can't know for sure the version of > upstream QEMU that is going to be used with Xen. > If we apply this patch and QEMU 1.5 is going to be used with Xen 4.2, > guests won't be able to use PV drivers. Is the right answer a lever to disable, rather than enable, it? A workaround for the situation you envisage is to use the device_model_args config option, not ideal though. > > > > > hw/i386/pc_piix.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > index d618570..e25012d 100644 > > --- a/hw/i386/pc_piix.c > > +++ b/hw/i386/pc_piix.c > > @@ -174,9 +174,6 @@ static void pc_init1(MemoryRegion *system_memory, > > pc_register_ferr_irq(gsi[13]); > > > > pc_vga_init(isa_bus, pci_enabled ? pci_bus : NULL); > > - if (xen_enabled()) { > > - pci_create_simple(pci_bus, -1, "xen-platform"); > > - } > > > > /* init basic PC hardware */ > > pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled()); > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel