All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc85xx: Enabling CPC conditionally based on hwconfig options
Date: Fri, 14 Jun 2013 14:39:26 -0500	[thread overview]
Message-ID: <1371238766.2996.6@snotra> (raw)
In-Reply-To: <3F1D9DCAAB49B94D88DBE05911FA4E6E070AF829@039-SN1MPN1-006.039d.mgd.msft.net> (from B37400@freescale.com on Fri Jun 14 00:26:18 2013)

On 06/14/2013 12:26:18 AM, Singh Sandeep-B37400 wrote:
> This was done with the intension of providing greater  
> configurability. When
> en_cpc is defined then it's entirely up to user to decide which cpcs  
> are to
> be enabled. Hence we do following:
> 
> if_defined("en_cpc"){
> 	only_then
> 		check_for_cpc_options;
> } else {
> 	enable_all_cpc;
> }

OK, I see.

What is the use case for enabling one cpc but not another?  What is the  
use case for disabling cpc at all?  The answer should go in the commit  
message.

-Scott

  reply	other threads:[~2013-06-14 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  6:59 [U-Boot] [PATCH] powerpc/mpc85xx: Enabling CPC conditionally based on hwconfig options Sandeep Singh
2013-06-13 16:39 ` Scott Wood
2013-06-14  5:26   ` Singh Sandeep-B37400
2013-06-14 19:39     ` Scott Wood [this message]
2013-07-02 10:01       ` Singh Sandeep-B37400
2014-07-02  6:14 Shaveta Leekha
2014-08-06 17:33 ` York Sun
2014-08-07  7:39   ` shaveta at freescale.com
2014-08-20 19:37 ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371238766.2996.6@snotra \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.