Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lorenz Haspel <lorenz@badgers.com>,
	devel@linuxdriverproject.org, gregkh@linuxfoundation.org,
	puff65537@bansheeslibrary.com, viro@zeniv.linux.org.uk,
	michael.banken@mathe.stud.uni-erlangen.de,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	linux-kernel@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions
Date: Mon, 17 Jun 2013 10:42:01 -0700	[thread overview]
Message-ID: <1371490921.2213.5.camel@joe-AO722> (raw)
In-Reply-To: <20130617172246.GI5008@mwanda>

On Mon, 2013-06-17 at 20:22 +0300, Dan Carpenter wrote:
> This will need to be redone because there were some buggy extra
> lines added toward the end of the patch.

[]

> > @@ -4867,10 +4884,12 @@ int set_tx_fn(bpctl_dev_t *pbpctl_dev, int tx_state)
> >  	    (pbpctl_dev->bp_caps & SW_CTL_CAP)) {
> >  		if ((pbpctl_dev->bp_tpl_flag))
> >  			return BP_NOT_CAP;
> > -	} else if ((pbpctl_dev_b = get_master_port_fn(pbpctl_dev))) {
> > -		if ((pbpctl_dev_b->bp_caps & TPL_CAP) &&
> > -		    (pbpctl_dev_b->bp_tpl_flag))
> > -			return BP_NOT_CAP;
> > +	} else {
> > +		pbpctl_dev_b = get_status_port_fn(pbpctl_dev);
> > +		if (pbpctl_dev_b)
> > +			if ((pbpctl_dev_b->bp_caps & TPL_CAP) &&
> > +			    (pbpctl_dev_b->bp_tpl_flag))
> > +				return BP_NOT_CAP;
> 
> Please put curly brace {} around multi-line indents.  Even though
> they are not needed for semantic reasons they make the code more
> readable.

Better still would be to combine the multi-statement ifs
into a single test and avoid the braces altogether.

		if (pbpctl_dev_b &&
		    pbpctl_dev_b->bp_caps & TPL_CAP &&
		    pbpctl_dev_b->bp_tpl_flag)