All of lore.kernel.org
 help / color / mirror / Atom feed
From: liguang <lig.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: liguang <lig.fnst@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH v2 5/5] ui: boolize 'full_screen'
Date: Tue, 18 Jun 2013 11:45:37 +0800	[thread overview]
Message-ID: <1371527137-16949-5-git-send-email-lig.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1371527137-16949-1-git-send-email-lig.fnst@cn.fujitsu.com>

full_screen parameter for functions sdl_display_init,
cocoa_display_init, curses_display_init should be
boolized by actual usage.
also boolize 'full_screen' in vl.c

it may be bold for cocoa, so if it hurts,
these changes can be dropped.

Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 include/ui/console.h |    6 +++---
 ui/curses.c          |    2 +-
 ui/sdl.c             |    2 +-
 vl.c                 |    4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/ui/console.h b/include/ui/console.h
index 98edf41..e927229 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -306,10 +306,10 @@ CharDriverState *vc_init(ChardevVC *vc);
 void register_vc_handler(VcHandler *handler);
 
 /* sdl.c */
-void sdl_display_init(DisplayState *ds, int full_screen, int no_frame);
+void sdl_display_init(DisplayState *ds, bool full_screen, int no_frame);
 
 /* cocoa.m */
-void cocoa_display_init(DisplayState *ds, int full_screen);
+void cocoa_display_init(DisplayState *ds, bool full_screen);
 
 /* vnc.c */
 void vnc_display_init(DisplayState *ds);
@@ -331,7 +331,7 @@ static inline int vnc_display_pw_expire(DisplayState *ds, time_t expires)
 #endif
 
 /* curses.c */
-void curses_display_init(DisplayState *ds, int full_screen);
+void curses_display_init(DisplayState *ds, bool full_screen);
 
 /* input.c */
 int index_from_key(const char *key);
diff --git a/ui/curses.c b/ui/curses.c
index 289a955..aaee070 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -336,7 +336,7 @@ static const DisplayChangeListenerOps dcl_ops = {
     .dpy_text_cursor = curses_cursor_position,
 };
 
-void curses_display_init(DisplayState *ds, int full_screen)
+void curses_display_init(DisplayState *ds, bool full_screen)
 {
 #ifndef _WIN32
     if (!isatty(1)) {
diff --git a/ui/sdl.c b/ui/sdl.c
index 39a42d6..643e095 100644
--- a/ui/sdl.c
+++ b/ui/sdl.c
@@ -868,7 +868,7 @@ static const DisplayChangeListenerOps dcl_ops = {
     .dpy_cursor_define = sdl_mouse_define,
 };
 
-void sdl_display_init(DisplayState *ds, int full_screen, int no_frame)
+void sdl_display_init(DisplayState *ds, bool full_screen, int no_frame)
 {
     int flags;
     uint8_t data = 0;
diff --git a/vl.c b/vl.c
index f94ec9c..d474f76 100644
--- a/vl.c
+++ b/vl.c
@@ -198,7 +198,7 @@ static int rtc_utc = 1;
 static int rtc_date_offset = -1; /* -1 means no change */
 QEMUClock *rtc_clock;
 int vga_interface_type = VGA_NONE;
-static int full_screen = 0;
+static bool full_screen = false;
 static int no_frame = 0;
 int no_quit = 0;
 CharDriverState *serial_hds[MAX_SERIAL_PORTS];
@@ -3520,7 +3520,7 @@ int main(int argc, char **argv, char **envp)
 		loadvm = optarg;
 		break;
             case QEMU_OPTION_full_screen:
-                full_screen = 1;
+                full_screen = true;
                 break;
             case QEMU_OPTION_no_frame:
                 no_frame = 1;
-- 
1.7.2.5

  parent reply	other threads:[~2013-06-18  3:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  3:45 [Qemu-devel] [PATCH v2 1/5] vnc: pass bool parameter for some functions liguang
2013-06-18  3:45 ` [Qemu-devel] [PATCH v2 2/5] vnc: boolize 'skipauth' liguang
2013-06-18  3:45 ` [Qemu-devel] [PATCH v2 3/5] qemu-char: use bool in qemu_chr_open_socket liguang
2013-06-19  8:28   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-20  0:21     ` li guang
2013-06-18  3:45 ` [Qemu-devel] [PATCH v2 4/5] sd: pass bool parameter for sd_init liguang
2013-06-19  8:30   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-18  3:45 ` liguang [this message]
2013-06-19  8:37   ` [Qemu-devel] [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen' Michael Tokarev
2013-06-19  8:17 ` [Qemu-devel] [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371527137-16949-5-git-send-email-lig.fnst@cn.fujitsu.com \
    --to=lig.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.