All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Sravan V Dodla <sravan@linux.vnet.ibm.com>
Cc: Dave Jones <davej@redhat.com>, trinity@vger.kernel.org
Subject: Re: Complie issues with trinity-2013-06-17 on s390
Date: Wed, 19 Jun 2013 19:06:38 +1000	[thread overview]
Message-ID: <1371632798.13340.7.camel@concordia> (raw)
In-Reply-To: <1371631009.4704.6.camel@oc6144502753.ibm.com>

On Wed, 2013-06-19 at 14:06 +0530, Sravan V Dodla wrote:
> On Wed, 2013-06-19 at 16:28 +1000, Michael Ellerman wrote:
> > On Wed, 2013-06-19 at 11:10 +0530, Sravan V Dodla wrote:
> > > On Tue, 2013-06-18 at 11:39 -0400, Dave Jones wrote:
> > > > On Tue, Jun 18, 2013 at 12:37:26PM +0530, Sravan V Dodla wrote:
> > > 
> > > > Does this help ?
> > > Thanks a lot Dave. That did help :)
> > > Still compilation does not complete successfully. I'm seeing the
> > > following issue on both ppc64 and s390x archs:
> > 
> > I have the following patch that I've been meaning to cleanup and send,
> > it works for me on ppc64.

> Yes Michael, it worked for me on ppc64. Thank you.

OK, see the two patches I sent to the list.


> I have also made the following changes to make it work for s390x, not
> sure of the impact though!

>--- kvm.c.orig	2013-06-19 14:04:37.814590066 +0530
> +++ kvm.c	2013-06-19 14:04:43.306415094 +0530
> @@ -87,8 +87,6 @@ static const struct ioctl kvm_ioctls[] =
>  	IOCTL(KVM_SET_VAPIC_ADDR),
>  #if defined(__s390__)
>  	IOCTL(KVM_S390_INTERRUPT),
> -	IOCTL(KVM_S390_STORE_STATUS_NOADDR),
> -	IOCTL(KVM_S390_STORE_STATUS_PREFIXED),
>  	IOCTL(KVM_S390_STORE_STATUS),
>  	IOCTL(KVM_S390_SET_INITIAL_PSW),
>  	IOCTL(KVM_S390_INITIAL_RESET),
> 

That looks correct. They are not actually ioctls, they are meant to be
used as arguments to the KVM_S390_STORE_STATUS ioctl. So I think that's
just a cut-and-paste bug in kvm.c.

You should send it as a proper patch.

cheers


      reply	other threads:[~2013-06-19  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  7:07 Complie issues with trinity-2013-06-17 on s390 Sravan V Dodla
2013-06-18 15:39 ` Dave Jones
2013-06-19  5:40   ` Sravan V Dodla
2013-06-19  6:28     ` Michael Ellerman
2013-06-19  8:36       ` Sravan V Dodla
2013-06-19  9:06         ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371632798.13340.7.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=davej@redhat.com \
    --cc=sravan@linux.vnet.ibm.com \
    --cc=trinity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.