From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur6Dv-0003EL-Rv for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:50:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ur6Du-0001fC-Jo for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:50:23 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:38291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur6Du-0001eQ-0v for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:50:22 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Jun 2013 18:15:41 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 14BFB3940053 for ; Mon, 24 Jun 2013 18:20:15 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5OCoBef25624830 for ; Mon, 24 Jun 2013 18:20:11 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5OCoEfk014799 for ; Mon, 24 Jun 2013 22:50:15 +1000 From: Wenchao Xia Date: Mon, 24 Jun 2013 20:48:38 +0800 Message-Id: <1372078125-31085-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com Global variable *mon_cmds and *info_cmds are not used any more, *cur_mon is not used in completion related functions. It is possible to create a monitor with different command table now, but that requirement do not exist yet, so not changed it to save trouble. Log command is still a special case now, may be it can be converted as sub group later. Patch 1-3 make sure the functions can be re-entered safely. V2: General: To discard *info_comds more graceful, help related function is modified to support sub command too. Patch 6/7 are added to improve help related functions. Patch 5: not directly return to make sure args are freed. Address Luiz's comments: Split patch into small serial. struct mon_cmd_t was not moved into header file, instead mon_cmnd_t *cmd_table is added as a member in struct Monitor. 5/7: drop original code comments for "info" in monitor_find_completion(). Wenchao Xia (7): 1 monitor: discard global variable *cur_mon in completion functions 2 monitor: discard global variable *mon_cmds 3 monitor: discard global variable *info_cmds in help functions 4 monitor: code move for parse_cmdline() 5 monitor: support sub commands in auto completion 6 monitor: improve "help" in auto completion for sub command 7 monitor: improve "help" to allow show tip of single command in sub group hmp-commands.hx | 2 +- include/monitor/readline.h | 3 +- monitor.c | 369 ++++++++++++++++++++++++++++---------------- readline.c | 5 +- 4 files changed, 239 insertions(+), 140 deletions(-)