All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
	armbru@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH V2 6/7] monitor: improve "help" in auto completion for sub command
Date: Mon, 24 Jun 2013 20:48:44 +0800	[thread overview]
Message-ID: <1372078125-31085-7-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1372078125-31085-1-git-send-email-xiawenc@linux.vnet.ibm.com>

Now special case "help *" in auto completion can work with sub commands,
such as "help info a*".

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 monitor.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/monitor.c b/monitor.c
index f364a0d..8b26b48 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4273,10 +4273,7 @@ static void monitor_find_completion_by_table(Monitor *mon,
                     cmd_completion(mon, str, QKeyCode_lookup[i]);
                 }
             } else if (!strcmp(cmd->name, "help|?")) {
-                readline_set_completion_index(mon->rs, strlen(str));
-                for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) {
-                    cmd_completion(mon, str, cmd->name);
-                }
+                monitor_find_completion_by_table(mon, cmd_table, p);
             }
             break;
         default:
-- 
1.7.1

  parent reply	other threads:[~2013-06-24 12:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 12:48 [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help Wenchao Xia
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 1/7] monitor: discard global variable *cur_mon in completion functions Wenchao Xia
2013-06-27 17:45   ` Eric Blake
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 2/7] monitor: discard global variable *mon_cmds Wenchao Xia
2013-06-27 17:57   ` Eric Blake
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 3/7] monitor: discard global variable *info_cmds in help functions Wenchao Xia
2013-06-27 19:26   ` Eric Blake
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 4/7] monitor: code move for parse_cmdline() Wenchao Xia
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 5/7] monitor: support sub commands in auto completion Wenchao Xia
2013-06-26  4:03   ` Wenchao Xia
2013-06-26 16:03     ` Luiz Capitulino
2013-06-27  1:43       ` Wenchao Xia
2013-06-24 12:48 ` Wenchao Xia [this message]
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 7/7] monitor: improve "help" to allow show tip of single command in sub group Wenchao Xia
2013-06-27 17:17 ` [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372078125-31085-7-git-send-email-xiawenc@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.