Re: [PATCH V3] xen: Don't perform SMP setup.

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2013-06-24 at 14:35 +0100, Anthony PERARD wrote:
> This is not needed and in case one want to start a guest with fewer vCPU
> than the maximum, the function will fail (infinite loop).
> 
> It's a "backport" of 5dbf1732940f94771e0b3c45c0960940276bc263.

For me this causes:
src/smp.c: In function ‘smp_probe’:
src/smp.c:87: warning: implicit declaration of function ‘usingXen’
In file included from src/post.c:26:
src/xen.h: At top level:
src/xen.h:14: error: static declaration of ‘usingXen’ follows non-static declaration
src/smp.c:87: note: previous implicit declaration of ‘usingXen’ was here
(and a bunch more).

I think you need a #include?

> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  src/smp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/smp.c b/src/smp.c
> index 3c36f8c..742e371 100644
> --- a/src/smp.c
> +++ b/src/smp.c
> @@ -84,6 +84,9 @@ int apic_id_is_present(u8 apic_id)
>  void
>  smp_probe(void)
>  {
> +    if (usingXen())
> +        return;
> +
>      ASSERT32FLAT();
>      u32 eax, ebx, ecx, cpuid_features;
>      cpuid(1, &eax, &ebx, &ecx, &cpuid_features);



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel