[PATCH] libelf: fix printing of pointers

[PATCH] libelf: fix printing of pointers

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

Printing them as decimal number, the more with 0x prefix, is confusing
and presumably relatively useless to most of us.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/libelf.h
+++ b/xen/include/xen/libelf.h
@@ -82,13 +82,13 @@ typedef uintptr_t elf_ptrval;
   /* Provides a type declaration for a HANDLE. */
 
 #ifdef __XEN__
-# define ELF_PRPTRVAL "lu"
+# define ELF_PRPTRVAL "lx"
   /*
-   * PRIuPTR is misdefined in xen/include/xen/inttypes.h, on 32-bit,
-   * to "u", when in fact uintptr_t is an unsigned long.
+   * PRIxPTR is misdefined in xen/include/xen/inttypes.h, on 32-bit,
+   * to "x", when in fact uintptr_t is an unsigned long.
    */
 #else
-# define ELF_PRPTRVAL PRIuPTR
+# define ELF_PRPTRVAL PRIxPTR
 #endif
   /* printf format a la PRId... for a PTRVAL */
 




[-- Attachment #2: libelf-pointer-printing.patch --]
[-- Type: text/plain, Size: 864 bytes --]

libelf: fix printing of pointers

Printing them as decimal number, the more with 0x prefix, is confusing
and presumably relatively useless to most of us.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/libelf.h
+++ b/xen/include/xen/libelf.h
@@ -82,13 +82,13 @@ typedef uintptr_t elf_ptrval;
   /* Provides a type declaration for a HANDLE. */
 
 #ifdef __XEN__
-# define ELF_PRPTRVAL "lu"
+# define ELF_PRPTRVAL "lx"
   /*
-   * PRIuPTR is misdefined in xen/include/xen/inttypes.h, on 32-bit,
-   * to "u", when in fact uintptr_t is an unsigned long.
+   * PRIxPTR is misdefined in xen/include/xen/inttypes.h, on 32-bit,
+   * to "x", when in fact uintptr_t is an unsigned long.
    */
 #else
-# define ELF_PRPTRVAL PRIuPTR
+# define ELF_PRPTRVAL PRIxPTR
 #endif
   /* printf format a la PRId... for a PTRVAL */
 

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Ping: [PATCH] libelf: fix printing of pointers

[Jan Beulich]

As fallout from the XSA-55 changes, I'd really like this to get into the
tree even if mostly cosmetic.

Jan

>>> On 21.06.13 at 12:21, "Jan Beulich" <JBeulich@suse.com> wrote:
> Printing them as decimal number, the more with 0x prefix, is confusing
> and presumably relatively useless to most of us.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/include/xen/libelf.h
> +++ b/xen/include/xen/libelf.h
> @@ -82,13 +82,13 @@ typedef uintptr_t elf_ptrval;
>    /* Provides a type declaration for a HANDLE. */
>  
>  #ifdef __XEN__
> -# define ELF_PRPTRVAL "lu"
> +# define ELF_PRPTRVAL "lx"
>    /*
> -   * PRIuPTR is misdefined in xen/include/xen/inttypes.h, on 32-bit,
> -   * to "u", when in fact uintptr_t is an unsigned long.
> +   * PRIxPTR is misdefined in xen/include/xen/inttypes.h, on 32-bit,
> +   * to "x", when in fact uintptr_t is an unsigned long.
>     */
>  #else
> -# define ELF_PRPTRVAL PRIuPTR
> +# define ELF_PRPTRVAL PRIxPTR
>  #endif
>    /* printf format a la PRId... for a PTRVAL */
>  

Re: [PATCH] libelf: fix printing of pointers

[Ian Campbell]

On Fri, 2013-06-21 at 11:21 +0100, Jan Beulich wrote:
> Printing them as decimal number, the more with 0x prefix, is confusing
> and presumably relatively useless to most of us.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Seems pretty obvious. Acked + applied.

Re: Ping: [PATCH] libelf: fix printing of pointers

[Ian Campbell]

On Wed, 2013-06-26 at 14:42 +0100, Jan Beulich wrote:
> As fallout from the XSA-55 changes, I'd really like this to get into the
> tree even if mostly cosmetic.

I applied, went to a meeting while it tested (along with some other
changes) and I've just pushed.