From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] introduce a cache options for PV disks Date: Thu, 27 Jun 2013 17:41:52 +0100 Message-ID: <1372351312.8976.44.camel@zakaz.uk.xensource.com> References: <20940.19076.523978.4704@mariner.uk.xensource.com> <20940.25537.183890.394352@mariner.uk.xensource.com> <1372350299.8976.26.camel@zakaz.uk.xensource.com> <20940.26810.227963.193621@mariner.uk.xensource.com> <20940.27003.695837.65658@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20940.27003.695837.65658@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, 2013-06-27 at 17:34 +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH v2] introduce a cache options for PV disks"): > > Ian Campbell writes ("Re: [PATCH v2] introduce a cache options for PV disks"): > > > On Thu, 2013-06-27 at 17:09 +0100, Ian Jackson wrote: > > > > + * So use of O_DIRECT is safe, in circumstances > > > > > > ^Some ? > > > > > > Otherwise I can't parse this sentence. > > > > Yes. > > In, fact, no. How about: > > * That is, if this option is enabled, use of O_DIRECT is safe, > * in circumstances where we would normally have avoided it as a > * workaround for that bug. This option is not relevant for ... I think I can parse it now. It doesn't really say what the option does though. I'd expect it to say something about "disabling the workaround" or "the backend may use O_DIRECT". Ian.