From: Ankur Raina <Ankur.Raina@kpitcummins.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"david.chen@diasemi.com" <david.chen@diasemi.com>
Subject: Re: [patch v1 1/1]regulator: fix for DA9055 regulator
Date: Fri, 28 Jun 2013 18:23:13 +0530 [thread overview]
Message-ID: <1372423993.1604.15.camel@ankurr1-desktop> (raw)
In-Reply-To: <20130628093359.GA27646@sirena.org.uk>
On Fri, 2013-06-28 at 10:33 +0100, Mark Brown wrote:
> On Fri, Jun 28, 2013 at 07:05:03AM +0000, Ankur Raina wrote:
> > This patch adds support for usage of GPIO's by multiple bucks and regulators
> > of DA9055 for enable-disable and voltage set selection.Without this patch regulator
> > control through GPIO would fail for more than one regulator/buck.
>
> This needs a much better patch description. What specifically is the
> bug that you are trying to fix here?
The DA9055 hardware supports regulator control through GPIO for all its regulators and bucks.
For this, the contolling GPIO should be set as GPI.The current driver requests gpio for every regulator
that is gpio controlled.This request fails in case of a regulator requesting a gpio, which is already
been assigned to other regulators. The corresponding register update for that regulator also fails.
This patch fixes the above issue.
next prev parent reply other threads:[~2013-06-28 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 7:05 [patch v1 1/1]regulator: fix for DA9055 regulator Ankur Raina
2013-06-28 9:33 ` Mark Brown
2013-06-28 12:53 ` Ankur Raina [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-27 14:11 Ankur Raina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372423993.1604.15.camel@ankurr1-desktop \
--to=ankur.raina@kpitcummins.com \
--cc=broonie@kernel.org \
--cc=david.chen@diasemi.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.