All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jia Hongtao <hongtao.jia@freescale.com>
To: <linuxppc-dev@lists.ozlabs.org>, <B07421@freescale.com>
Cc: b38951@freescale.com
Subject: [PATCH] powerpc/msi: Fix compile error on mpc83xx
Date: Tue, 2 Jul 2013 09:36:37 +0800	[thread overview]
Message-ID: <1372728997-31665-1-git-send-email-hongtao.jia@freescale.com> (raw)

mpic_get_primary_version() is not defined when not using MPIC.
The compile error log like:

arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
fsl_msi.c:(.text+0x150c): undefined reference to `fsl_mpic_primary_get_version'

Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
---
 arch/powerpc/include/asm/mpic.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mpic.h
index ea6bf72..97b5a63 100644
--- a/arch/powerpc/include/asm/mpic.h
+++ b/arch/powerpc/include/asm/mpic.h
@@ -394,7 +394,14 @@ struct mpic
 #define	MPIC_REGSET_TSI108		MPIC_REGSET(1)	/* Tsi108/109 PIC */
 
 /* Get the version of primary MPIC */
+#ifdef CONFIG_MPIC
 extern u32 fsl_mpic_primary_get_version(void);
+#else
+static inline u32 fsl_mpic_primary_get_version(void)
+{
+	return 0;
+}
+#endif
 
 /* Allocate the controller structure and setup the linux irq descs
  * for the range if interrupts passed in. No HW initialization is
-- 
1.8.0

             reply	other threads:[~2013-07-02  2:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02  1:36 Jia Hongtao [this message]
2013-07-10  2:04 ` [PATCH] powerpc/msi: Fix compile error on mpc83xx Jia Hongtao-B38951
2013-07-22  2:00   ` Jia Hongtao-B38951
2013-07-22 17:18     ` Scott Wood
2013-07-23  1:58       ` Jia Hongtao-B38951
  -- strict thread matches above, loose matches on Subject: below --
2018-10-19  6:12 Christophe Leroy
2018-10-19  6:12 ` Christophe Leroy
2013-07-02  1:34 Jia Hongtao
2013-07-02  2:26 ` Jia Hongtao-B38951

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372728997-31665-1-git-send-email-hongtao.jia@freescale.com \
    --to=hongtao.jia@freescale.com \
    --cc=B07421@freescale.com \
    --cc=b38951@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.