On Wed, 2013-05-29 at 15:13 +0200, Arend van Spriel wrote:
> From: Franky Lin <frankyl@broadcom.com>
> 
> Add missing firmware file for the BCM43241 SDIO device. The firmware
> version is v6.10.170.4
> 
> Reported-by: Alex Courbot <acourbot@nvidia.com>
> Signed-off-by: Franky Lin <frankyl@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> Hi Ben,
> 
> Somehow this firmware got forgotten although brcmfmac has support for
> the device for a while now.
> 
> Regards,
> Arend
> ---
>  WHENCE                 |    1 +
>  brcm/brcmfmac43241.bin |  Bin 0 -> 414238 bytes
>  2 files changed, 1 insertion(+)
>  create mode 100644 brcm/brcmfmac43241.bin
> 
> diff --git a/WHENCE b/WHENCE
> index ef64612..5eca1d0 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -1652,6 +1652,7 @@ Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.
>  
>  File: brcm/bcm4329-fullmac-4.bin
>  File: brcm/brcmfmac43236b.bin
> +File: brcm/brcmfmac43241.bin
>  File: brcm/brcmfmac4329.bin
>  File: brcm/brcmfmac4330.bin
>  File: brcm/brcmfmac4334.bin
[...]

Unless you're doing something very clever with macros, I don't believe
you've posted any driver code that uses this file... or several of the
others.  The current driver in net-next (I don't know what you've sent
to Nvidia) appears to request only these files:

- brcm/brcmfmac43143.bin
- brcm/brcmfmac43236b.bin
- brcm/brcmfmac43242a.bin
- brcm/brcmfmac-sdio.bin
- brcm/brcmfmac-sdio.txt

Looking through the git history, I can see that various other names have
been used:

- brcm/bcm4329-fullmac-4.bin (renamed to brcm/brcmfmac-sdio.bin)
- brcm/bcm4329-fullmac-4.txt (renamed to brcm/brcmfmac-sdio.txt)
- brcm/brcmfmac-usb.bin (renamed to brcm/brcmfmac43236b.bin)
- brcm/brcmfmac.bin (renamed to brcm/brcmfmac-sdio.bin)
- brcm/brcmfmac.txt (renamed to brcm/brcmfmac-sdio.txt)

So I think, before this patch is applied, you owe me and David patches
to:

1. Add brcm/brcmfmac43143.bin, brcm/brcmfmac43242a.bin and
brcm/brcmfmac-sdio.txt.
2. Rename brcm/bcm4329-fullmac-4.bin to brcm/brcmfmac-sdio.bin.
3. Add symlinks from all the old names to the new names.  (As
linux-firmware should support old in-tree drivers indefinitely.)

and you owe linux-wireless some driver patches.

linux-firmware.git is not the appropriate place to send firmware used
only by out-of-tree code, and any firmware blob that has never been
referenced by in-tree code is subject to removal.

Ben.

-- 
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.