From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwGBN-0002uY-So for qemu-devel@nongnu.org; Mon, 08 Jul 2013 14:29:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwGBK-0007t4-1J for qemu-devel@nongnu.org; Mon, 08 Jul 2013 14:29:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwGBJ-0007su-MN for qemu-devel@nongnu.org; Mon, 08 Jul 2013 14:29:01 -0400 Date: Mon, 8 Jul 2013 21:30:14 +0300 From: "Michael S. Tsirkin" Message-ID: <1373307914-18543-3-git-send-email-mst@redhat.com> References: <1373307914-18543-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373307914-18543-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/4] loader: allow adding ROMs in done callbacks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , seabios@seabios.org, lersek@redhat.com Don't abort if machine done callbacks add ROMs. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c | 6 +++++- include/hw/loader.h | 1 + vl.c | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 1ead722..3f1d89b 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -743,10 +743,14 @@ int rom_load_all(void) rom->isrom = int128_nz(section.size) && memory_region_is_rom(section.mr); } qemu_register_reset(rom_reset, NULL); - roms_loaded = 1; return 0; } +void rom_load_done(void) +{ + roms_loaded = 1; +} + void rom_set_fw(FWCfgState *f) { fw_cfg = f; diff --git a/include/hw/loader.h b/include/hw/loader.h index b39e7d1..976e5cd 100644 --- a/include/hw/loader.h +++ b/include/hw/loader.h @@ -31,6 +31,7 @@ int rom_add_blob(const char *name, const void *blob, size_t len, int rom_add_elf_program(const char *name, void *data, size_t datasize, size_t romsize, hwaddr addr); int rom_load_all(void); +void rom_load_done(void); void rom_set_fw(FWCfgState *f); int rom_copy(uint8_t *dest, hwaddr addr, size_t size); void *rom_ptr(hwaddr addr); diff --git a/vl.c b/vl.c index 6d9fd7d..8190504 100644 --- a/vl.c +++ b/vl.c @@ -4377,6 +4377,9 @@ int main(int argc, char **argv, char **envp) qemu_register_reset(qbus_reset_all_fn, sysbus_get_default()); qemu_run_machine_init_done_notifiers(); + /* Done notifiers can load ROMs */ + rom_load_done(); + qemu_system_reset(VMRESET_SILENT); if (loadvm) { if (load_vmstate(loadvm) < 0) { -- MST