All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>, David Airlie <airlied@linux.ie>,
	Rob Clark <robdclark@gmail.com>, Dave Airlie <airlied@redhat.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Benoit Parrot <bparrot@ti.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Darren Etheridge <detheridge@ti.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 01/12] drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe
Date: Wed, 10 Jul 2013 16:57:36 +0100	[thread overview]
Message-ID: <1373471889-18107-1-git-send-email-wsa@the-dreams.de> (raw)

Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.

Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c  |    6 ------
 drivers/gpu/drm/tilcdc/tilcdc_slave.c  |    6 ------
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c |    6 ------
 3 files changed, 18 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 86c6732..f0ff5f8 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -16,7 +16,6 @@
  */
 
 #include <linux/pinctrl/pinmux.h>
-#include <linux/pinctrl/consumer.h>
 #include <linux/backlight.h>
 #include <video/display_timing.h>
 #include <video/of_display_timing.h>
@@ -358,7 +357,6 @@ static int panel_probe(struct platform_device *pdev)
 	struct device_node *node = pdev->dev.of_node;
 	struct panel_module *panel_mod;
 	struct tilcdc_module *mod;
-	struct pinctrl *pinctrl;
 	int ret = -EINVAL;
 
 
@@ -376,10 +374,6 @@ static int panel_probe(struct platform_device *pdev)
 
 	tilcdc_module_init(mod, "panel", &panel_module_ops);
 
-	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
-	if (IS_ERR(pinctrl))
-		dev_warn(&pdev->dev, "pins are not configured\n");
-
 
 	panel_mod->timings = of_get_display_timings(node);
 	if (!panel_mod->timings) {
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave.c b/drivers/gpu/drm/tilcdc/tilcdc_slave.c
index dfffaf0..2bdbe5e 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_slave.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_slave.c
@@ -18,7 +18,6 @@
 #include <linux/i2c.h>
 #include <linux/of_i2c.h>
 #include <linux/pinctrl/pinmux.h>
-#include <linux/pinctrl/consumer.h>
 #include <drm/drm_encoder_slave.h>
 
 #include "tilcdc_drv.h"
@@ -296,7 +295,6 @@ static int slave_probe(struct platform_device *pdev)
 	struct device_node *i2c_node;
 	struct slave_module *slave_mod;
 	struct tilcdc_module *mod;
-	struct pinctrl *pinctrl;
 	uint32_t i2c_phandle;
 	struct i2c_adapter *slavei2c;
 	int ret = -EINVAL;
@@ -342,10 +340,6 @@ static int slave_probe(struct platform_device *pdev)
 
 	tilcdc_module_init(mod, "slave", &slave_module_ops);
 
-	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
-	if (IS_ERR(pinctrl))
-		dev_warn(&pdev->dev, "pins are not configured\n");
-
 	tilcdc_slave_probedefer(false);
 
 	return 0;
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 925c7cd..a38be60 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -20,7 +20,6 @@
 #include <linux/gpio.h>
 #include <linux/of_gpio.h>
 #include <linux/pinctrl/pinmux.h>
-#include <linux/pinctrl/consumer.h>
 
 #include "tilcdc_drv.h"
 
@@ -327,7 +326,6 @@ static int tfp410_probe(struct platform_device *pdev)
 	struct device_node *i2c_node;
 	struct tfp410_module *tfp410_mod;
 	struct tilcdc_module *mod;
-	struct pinctrl *pinctrl;
 	uint32_t i2c_phandle;
 	int ret = -EINVAL;
 
@@ -345,10 +343,6 @@ static int tfp410_probe(struct platform_device *pdev)
 
 	tilcdc_module_init(mod, "tfp410", &tfp410_module_ops);
 
-	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
-	if (IS_ERR(pinctrl))
-		dev_warn(&pdev->dev, "pins are not configured\n");
-
 	if (of_property_read_u32(node, "i2c", &i2c_phandle)) {
 		dev_err(&pdev->dev, "could not get i2c bus phandle\n");
 		goto fail;
-- 
1.7.10.4


             reply	other threads:[~2013-07-10 15:58 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 15:57 Wolfram Sang [this message]
2013-07-10 15:57 ` [PATCH 02/12] drivers/i2c/busses: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2013-07-10 15:57   ` Wolfram Sang
2013-08-07 15:37   ` Wolfram Sang
2013-08-07 15:37     ` Wolfram Sang
2013-07-10 15:57 ` [PATCH 03/12] drivers/misc: " Wolfram Sang
2013-07-10 23:13   ` Arnd Bergmann
2013-07-20 17:45     ` Linus Walleij
2013-07-20 17:50       ` Greg KH
2013-07-10 15:57 ` [PATCH 04/12] drivers/mmc/host: " Wolfram Sang
2013-07-10 15:57   ` Wolfram Sang
2013-07-10 15:57   ` Wolfram Sang
2013-07-10 19:57   ` Marek Vasut
2013-07-10 19:57     ` Marek Vasut
2013-07-12  3:39   ` Barry Song
2013-07-12  3:39     ` Barry Song
2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: " Wolfram Sang
2013-07-10 15:57   ` Wolfram Sang
2013-08-02 15:51   ` Artem Bityutskiy
2013-08-02 15:51     ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang
2013-07-10 15:57   ` Wolfram Sang
2013-07-11  2:14   ` Huang Shijie
2013-07-11  2:14     ` Huang Shijie
2013-07-11  2:19     ` Huang Shijie
2013-07-11  2:19       ` Huang Shijie
2013-07-20 17:48   ` Linus Walleij
2013-07-20 17:48     ` Linus Walleij
2013-08-02 15:37   ` Artem Bityutskiy
2013-08-02 15:37     ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: " Wolfram Sang
2013-07-10 21:02   ` Marc Kleine-Budde
2013-07-10 21:14     ` David Miller
2013-07-12  0:18   ` David Miller
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
2013-07-11  7:40   ` Nicolas Ferre
2013-07-12  0:19   ` David Miller
2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang
2013-07-12  0:19   ` David Miller
2013-07-12  0:19     ` David Miller
2013-07-10 15:57 ` [PATCH 10/12] drivers/pwm: " Wolfram Sang
2013-07-10 15:57 ` [PATCH 11/12] drivers/tty/serial: " Wolfram Sang
2013-07-11  7:40   ` Nicolas Ferre
2013-07-11  7:40     ` Nicolas Ferre
2013-07-20 17:46     ` Linus Walleij
2013-07-20 17:50       ` Greg KH
2013-07-10 15:57 ` [PATCH 12/12] drivers/video: " Wolfram Sang
2013-07-10 15:57   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373471889-18107-1-git-send-email-wsa@the-dreams.de \
    --to=wsa@the-dreams.de \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=bparrot@ti.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=detheridge@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.