From: Wolfram Sang <wsa@the-dreams.de> To: linux-kernel@vger.kernel.org Cc: Wolfram Sang <wsa@the-dreams.de>, David Woodhouse <dwmw2@infradead.org>, Artem Bityutskiy <artem.bityutskiy@linux.intel.com>, Huang Shijie <b32955@freescale.com>, Bill Pemberton <wfp5p@virginia.edu>, Fabio Estevam <fabio.estevam@freescale.com>, linux-mtd@lists.infradead.org Subject: [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe Date: Wed, 10 Jul 2013 16:57:41 +0100 [thread overview] Message-ID: <1373471889-18107-6-git-send-email-wsa@the-dreams.de> (raw) In-Reply-To: <1373471889-18107-1-git-send-email-wsa@the-dreams.de> Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 25ecfa1..fd49464 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -26,7 +26,6 @@ #include <linux/interrupt.h> #include <linux/module.h> #include <linux/mtd/partitions.h> -#include <linux/pinctrl/consumer.h> #include <linux/of.h> #include <linux/of_device.h> #include <linux/of_mtd.h> @@ -516,7 +515,6 @@ err_clock: static int acquire_resources(struct gpmi_nand_data *this) { - struct pinctrl *pinctrl; int ret; ret = acquire_register_block(this, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME); @@ -535,19 +533,12 @@ static int acquire_resources(struct gpmi_nand_data *this) if (ret) goto exit_dma_channels; - pinctrl = devm_pinctrl_get_select_default(&this->pdev->dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(pinctrl); - goto exit_pin; - } - ret = gpmi_get_clks(this); if (ret) goto exit_clock; return 0; exit_clock: -exit_pin: release_dma_channels(this); exit_dma_channels: release_bch_irq(this); -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de> To: linux-kernel@vger.kernel.org Cc: Fabio Estevam <fabio.estevam@freescale.com>, Wolfram Sang <wsa@the-dreams.de>, Artem Bityutskiy <artem.bityutskiy@linux.intel.com>, Huang Shijie <b32955@freescale.com>, Bill Pemberton <wfp5p@virginia.edu>, linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org> Subject: [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe Date: Wed, 10 Jul 2013 16:57:41 +0100 [thread overview] Message-ID: <1373471889-18107-6-git-send-email-wsa@the-dreams.de> (raw) In-Reply-To: <1373471889-18107-1-git-send-email-wsa@the-dreams.de> Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 25ecfa1..fd49464 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -26,7 +26,6 @@ #include <linux/interrupt.h> #include <linux/module.h> #include <linux/mtd/partitions.h> -#include <linux/pinctrl/consumer.h> #include <linux/of.h> #include <linux/of_device.h> #include <linux/of_mtd.h> @@ -516,7 +515,6 @@ err_clock: static int acquire_resources(struct gpmi_nand_data *this) { - struct pinctrl *pinctrl; int ret; ret = acquire_register_block(this, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME); @@ -535,19 +533,12 @@ static int acquire_resources(struct gpmi_nand_data *this) if (ret) goto exit_dma_channels; - pinctrl = devm_pinctrl_get_select_default(&this->pdev->dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(pinctrl); - goto exit_pin; - } - ret = gpmi_get_clks(this); if (ret) goto exit_clock; return 0; exit_clock: -exit_pin: release_dma_channels(this); exit_dma_channels: release_bch_irq(this); -- 1.7.10.4
next prev parent reply other threads:[~2013-07-10 16:01 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-10 15:57 [PATCH 01/12] drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang 2013-07-10 15:57 ` [PATCH 02/12] drivers/i2c/busses: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-08-07 15:37 ` Wolfram Sang 2013-08-07 15:37 ` Wolfram Sang 2013-07-10 15:57 ` [PATCH 03/12] drivers/misc: " Wolfram Sang 2013-07-10 23:13 ` Arnd Bergmann 2013-07-20 17:45 ` Linus Walleij 2013-07-20 17:50 ` Greg KH 2013-07-10 15:57 ` [PATCH 04/12] drivers/mmc/host: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-07-10 19:57 ` Marek Vasut 2013-07-10 19:57 ` Marek Vasut 2013-07-12 3:39 ` Barry Song 2013-07-12 3:39 ` Barry Song 2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-08-02 15:51 ` Artem Bityutskiy 2013-08-02 15:51 ` Artem Bityutskiy 2013-07-10 15:57 ` Wolfram Sang [this message] 2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang 2013-07-11 2:14 ` Huang Shijie 2013-07-11 2:14 ` Huang Shijie 2013-07-11 2:19 ` Huang Shijie 2013-07-11 2:19 ` Huang Shijie 2013-07-20 17:48 ` Linus Walleij 2013-07-20 17:48 ` Linus Walleij 2013-08-02 15:37 ` Artem Bityutskiy 2013-08-02 15:37 ` Artem Bityutskiy 2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: " Wolfram Sang 2013-07-10 21:02 ` Marc Kleine-Budde 2013-07-10 21:14 ` David Miller 2013-07-12 0:18 ` David Miller 2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang 2013-07-11 7:40 ` Nicolas Ferre 2013-07-12 0:19 ` David Miller 2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang 2013-07-12 0:19 ` David Miller 2013-07-12 0:19 ` David Miller 2013-07-10 15:57 ` [PATCH 10/12] drivers/pwm: " Wolfram Sang 2013-07-10 15:57 ` [PATCH 11/12] drivers/tty/serial: " Wolfram Sang 2013-07-11 7:40 ` Nicolas Ferre 2013-07-11 7:40 ` Nicolas Ferre 2013-07-20 17:46 ` Linus Walleij 2013-07-20 17:50 ` Greg KH 2013-07-10 15:57 ` [PATCH 12/12] drivers/video: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1373471889-18107-6-git-send-email-wsa@the-dreams.de \ --to=wsa@the-dreams.de \ --cc=artem.bityutskiy@linux.intel.com \ --cc=b32955@freescale.com \ --cc=dwmw2@infradead.org \ --cc=fabio.estevam@freescale.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=wfp5p@virginia.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.