From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwyZT-0001NA-FH for qemu-devel@nongnu.org; Wed, 10 Jul 2013 13:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwyZS-0004g3-Ji for qemu-devel@nongnu.org; Wed, 10 Jul 2013 13:52:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwyZS-0004fq-C4 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 13:52:54 -0400 From: Luiz Capitulino Date: Wed, 10 Jul 2013 13:52:42 -0400 Message-Id: <1373478767-20965-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1373478767-20965-1-git-send-email-lcapitulino@redhat.com> References: <1373478767-20965-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PULL 1/6] qemu-char: Fix ringbuf option size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com From: Markus Armbruster Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER" assertion. Broken in commit 1da48c65. Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 18c42a3..800d6a6 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3115,7 +3115,7 @@ static void qemu_chr_parse_memory(QemuOpts *opts, ChardevBackend *backend, backend->memory = g_new0(ChardevMemory, 1); - val = qemu_opt_get_number(opts, "size", 0); + val = qemu_opt_get_size(opts, "size", 0); if (val != 0) { backend->memory->has_size = true; backend->memory->size = val; -- 1.8.1.4