From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-f49.google.com ([209.85.160.49]:65392 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755838Ab3GKJGh (ORCPT ); Thu, 11 Jul 2013 05:06:37 -0400 From: Ming Lei To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Oliver Neukum , Alan Stern , linux-input@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org Subject: [PATCH 00/50] USB: cleanup spin_lock in URB->complete() Date: Thu, 11 Jul 2013 17:05:23 +0800 Message-Id: <1373533573-12272-1-git-send-email-ming.lei@canonical.com> (sfid-20130711_110658_363692_647EE930) Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, As we are going to run URB->complete() in tasklet context[1][2], and hard interrupt may be enabled when running URB completion handler[3], so we might need to disable interrupt when acquiring one lock in the completion handler for the below reasons: - URB->complete() holds a subsystem wide lock which may be acquired in another hard irq context, and the subsystem wide lock is acquired by spin_lock()/read_lock()/write_lock() in complete() - URB->complete() holds a private lock with spin_lock()/read_lock()/write_lock() but driver may export APIs to make other drivers acquire the same private lock in its interrupt handler. For the sake of safety and making the change simple, this patch set converts all spin_lock()/read_lock()/write_lock() in completion handler path into their irqsave version mechanically. But if you are sure the above two cases do not happen in your driver, please let me know and I can drop the unnecessary change. Also if you find some conversions are missed, also please let me know so that I can add it in the next round. [1], http://marc.info/?l=linux-usb&m=137286322526312&w=2 [2], http://marc.info/?l=linux-usb&m=137286326726326&w=2 [3], http://marc.info/?l=linux-usb&m=137286330626363&w=2 drivers/bluetooth/bfusb.c | 12 ++++---- drivers/bluetooth/btusb.c | 5 ++-- drivers/hid/usbhid/hid-core.c | 5 ++-- drivers/input/misc/cm109.c | 10 ++++--- drivers/isdn/hardware/mISDN/hfcsusb.c | 36 ++++++++++++----------- drivers/media/dvb-core/dvb_demux.c | 17 +++++++---- drivers/media/usb/cx231xx/cx231xx-audio.c | 6 ++++ drivers/media/usb/cx231xx/cx231xx-core.c | 10 ++++--- drivers/media/usb/cx231xx/cx231xx-vbi.c | 5 ++-- drivers/media/usb/em28xx/em28xx-audio.c | 3 ++ drivers/media/usb/em28xx/em28xx-core.c | 5 ++-- drivers/media/usb/sn9c102/sn9c102_core.c | 7 +++-- drivers/media/usb/tlg2300/pd-alsa.c | 3 ++ drivers/media/usb/tlg2300/pd-video.c | 5 ++-- drivers/media/usb/tm6000/tm6000-video.c | 5 ++-- drivers/net/usb/cdc-phonet.c | 5 ++-- drivers/net/usb/hso.c | 38 ++++++++++++++----------- drivers/net/usb/kaweth.c | 7 +++-- drivers/net/usb/rtl8150.c | 5 ++-- drivers/net/wireless/ath/ath9k/hif_usb.c | 29 ++++++++++--------- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 9 +++--- drivers/net/wireless/ath/ath9k/wmi.c | 11 +++---- drivers/net/wireless/ath/carl9170/rx.c | 5 ++-- drivers/net/wireless/libertas/if_usb.c | 5 ++-- drivers/net/wireless/libertas_tf/if_usb.c | 6 ++-- drivers/net/wireless/zd1211rw/zd_usb.c | 21 ++++++++------ drivers/staging/bcm/InterfaceRx.c | 5 ++-- drivers/staging/btmtk_usb/btmtk_usb.c | 5 ++-- drivers/staging/ced1401/usb1401.c | 35 ++++++++++++----------- drivers/staging/vt6656/usbpipe.c | 9 +++--- drivers/usb/class/cdc-wdm.c | 16 +++++++---- drivers/usb/class/usblp.c | 10 ++++--- drivers/usb/core/devio.c | 5 ++-- drivers/usb/misc/adutux.c | 10 ++++--- drivers/usb/misc/iowarrior.c | 5 ++-- drivers/usb/misc/ldusb.c | 7 +++-- drivers/usb/misc/legousbtower.c | 5 ++-- drivers/usb/misc/usbtest.c | 10 ++++--- drivers/usb/misc/uss720.c | 6 +++- drivers/usb/serial/cyberjack.c | 15 ++++++---- drivers/usb/serial/digi_acceleport.c | 23 ++++++++------- drivers/usb/serial/io_edgeport.c | 14 +++++---- drivers/usb/serial/io_ti.c | 5 ++-- drivers/usb/serial/mos7720.c | 5 ++-- drivers/usb/serial/mos7840.c | 5 ++-- drivers/usb/serial/quatech2.c | 5 ++-- drivers/usb/serial/sierra.c | 9 +++--- drivers/usb/serial/symbolserial.c | 5 ++-- drivers/usb/serial/ti_usb_3410_5052.c | 9 +++--- drivers/usb/serial/usb_wwan.c | 5 ++-- sound/usb/caiaq/audio.c | 5 ++-- sound/usb/midi.c | 5 ++-- sound/usb/misc/ua101.c | 14 +++++++-- sound/usb/usx2y/usbusx2yaudio.c | 4 +++ 54 files changed, 322 insertions(+), 209 deletions(-) Thanks, -- Ming Lei