From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC Patch v2 01/16] xen: introduce new hypercall
 to reset vcpu
Date: Thu, 11 Jul 2013 11:01:58 +0100
Message-ID: <1373536918.5453.164.camel@hastur.hellion.org.uk>
References: <1373531748-12547-1-git-send-email-wency@cn.fujitsu.com>
	<1373531748-12547-2-git-send-email-wency@cn.fujitsu.com>
	<51DE7E65.6080507@citrix.com> <51DE81B6.9050502@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51DE81B6.9050502@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, Ye Wei <wei.ye1987@gmail.com>, xen-devl <xen-devel@lists.xen.org>, Hong Tao <bobby.hong@huawei.com>, Xu Yao <xuyao.xu@huawei.com>, Shriram Rajagopalan <rshriram@cs.ubc.ca>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2013-07-11 at 17:58 +0800, Wen Congyang wrote:

> >> +    BUG_ON(!cpumask_empty(d->domain_dirty_cpumask));
> > 
> > This looks bogus.  What guarantee is there (other than the toolstack
> > issuing appropriate hypercalls in an appropriate order) that this is
> > actually true.
> 
> Hmm, these codes are copied from this function:
> domain_relinquish_resources()

That's called under very different circumstances though. Specifically
during domain teardown when the vcpus are necessarily all quiescent.