From: Steven Rostedt <rostedt@goodmis.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()
Date: Mon, 15 Jul 2013 12:20:51 -0400 [thread overview]
Message-ID: <1373905251.17876.150.camel@gandalf.local.home> (raw)
In-Reply-To: <51E35A7D.8000008@asianux.com>
On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote:
> Hello Frederic and Ingo:
Are you trying to go around me? I wrote this code and I'm one of the
maintainers for it. Your issue is very minor, and can wait till other
things get done first.
You said my previous patch fixed your problem, right? Then I'll add your
tested by and push it in due course.
I'll also get around to adding __init's to other functions too. But it
is *very* low on the totem pole of importance.
>
> Could you provide your suggestions or completions for it ?
>
> The trace_selftest_startup_* funcitons are mostly added by you without
> '__init', do you have additional considerations about it (intend to have
> no '__init') ?
>
> If no reply, I recommend to keep no '__init': apply this patch or
> regress part of the patch "f1ed7c7 ftrace: Do not run selftest if
> command line parameter is set" (at least, it can avoid related warnings
> and treat all *selftest* fair).
It's a compile time warning that's a false positive. Not a run time
crash or other issue of importance. It can wait, relax. Otherwise you
are starting to become annoying.
-- Steve
next prev parent reply other threads:[~2013-07-15 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 0:31 [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph() Chen Gang
2013-07-11 16:47 ` Steven Rostedt
2013-07-11 23:51 ` Chen Gang
2013-07-12 1:41 ` Steven Rostedt
2013-07-12 1:58 ` Chen Gang
2013-07-12 2:38 ` Steven Rostedt
2013-07-12 3:04 ` Chen Gang
2013-07-12 7:20 ` Chen Gang
2013-07-15 2:12 ` Chen Gang
2013-07-15 16:20 ` Steven Rostedt [this message]
2013-07-16 0:22 ` Chen Gang
2013-07-17 0:52 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373905251.17876.150.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.