* [PATCH RESEND] video: mxsfb: Let device core handle pinctrl
@ 2013-07-15 21:31 Fabio Estevam
2013-07-17 22:24 ` Andrew Morton
2013-07-26 7:46 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-07-15 21:31 UTC (permalink / raw)
To: linux-fbdev
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove
devm_pinctrl_get_select_default() from the driver.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
---
Andrew,
Should this go via your tree?
drivers/video/mxsfb.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 21223d4..9d6a286 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -46,7 +46,6 @@
#include <linux/clk.h>
#include <linux/dma-mapping.h>
#include <linux/io.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/fb.h>
#include <linux/regulator/consumer.h>
#include <video/of_display_timing.h>
@@ -877,7 +876,6 @@ static int mxsfb_probe(struct platform_device *pdev)
struct mxsfb_info *host;
struct fb_info *fb_info;
struct fb_modelist *modelist;
- struct pinctrl *pinctrl;
int ret;
if (of_id)
@@ -909,12 +907,6 @@ static int mxsfb_probe(struct platform_device *pdev)
host->devdata = &mxsfb_devdata[pdev->id_entry->driver_data];
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl)) {
- ret = PTR_ERR(pinctrl);
- goto fb_release;
- }
-
host->clk = devm_clk_get(&host->pdev->dev, NULL);
if (IS_ERR(host->clk)) {
ret = PTR_ERR(host->clk);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] video: mxsfb: Let device core handle pinctrl
2013-07-15 21:31 [PATCH RESEND] video: mxsfb: Let device core handle pinctrl Fabio Estevam
@ 2013-07-17 22:24 ` Andrew Morton
2013-07-26 7:46 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2013-07-17 22:24 UTC (permalink / raw)
To: linux-fbdev
On Mon, 15 Jul 2013 18:31:24 -0300 Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
> we can rely on device core for handling pinctrl, so remove
> devm_pinctrl_get_select_default() from the driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> Andrew,
>
> Should this go via your tree?
Well, no, it should really be reviewed by and merged by
Jean-Christophe. Is there a problem in fbdev land?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] video: mxsfb: Let device core handle pinctrl
2013-07-15 21:31 [PATCH RESEND] video: mxsfb: Let device core handle pinctrl Fabio Estevam
2013-07-17 22:24 ` Andrew Morton
@ 2013-07-26 7:46 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 7:46 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On 16/07/13 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
> we can rely on device core for handling pinctrl, so remove
> devm_pinctrl_get_select_default() from the driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
Thanks, I've applied this into my 3.12/fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-26 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-15 21:31 [PATCH RESEND] video: mxsfb: Let device core handle pinctrl Fabio Estevam
2013-07-17 22:24 ` Andrew Morton
2013-07-26 7:46 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.