From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: James Hogan <jhogan@kernel.org>
Cc: Paul Burton <paul.burton@mips.com>,
linux-mips <linux-mips@linux-mips.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 4/4] rseq/selftests: Implement MIPS support
Date: Fri, 15 Jun 2018 13:37:19 -0400 (EDT) [thread overview]
Message-ID: <1373980460.14412.1529084239034.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20180615105809.GB7603@jamesdev>
----- On Jun 15, 2018, at 6:58 AM, James Hogan jhogan@kernel.org wrote:
> On Thu, Jun 14, 2018 at 04:52:10PM -0700, Paul Burton wrote:
>> +#define __RSEQ_ASM_DEFINE_TABLE(version, flags, start_ip, \
>
> Nit: technically all these \'s are on 81st column...
>
>> +#define __RSEQ_ASM_DEFINE_ABORT(table_label, label, teardown, \
>> + abort_label, version, flags, \
>> + start_ip, post_commit_offset, abort_ip) \
>> + ".balign 32\n\t" \
>
> ARM doesn't do this for DEFINE_ABORT. Is it intentional that we do for
> MIPS?
Given that include/uapi/linux/rseq.h declares struct rseq_cs as
__attribute__((aligned(4 * sizeof(__u64)))), and considering this
comment:
/*
* struct rseq_cs is aligned on 4 * 8 bytes to ensure it is always
* contained within a single cache-line. It is usually declared as
* link-time constant data.
*/
The .balign 32 is the right thing to do here. I will add a .balign 32
to ARM selftests code as well.
Thanks,
Mathieu
>
> Thanks
> James
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2018-06-15 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 23:52 [PATCH 0/4] MIPS: Restartable sequences (rseq) support Paul Burton
2018-06-14 23:52 ` Paul Burton
2018-06-14 23:52 ` [PATCH 1/4] MIPS: Add support for restartable sequences Paul Burton
2018-06-14 23:52 ` Paul Burton
2018-06-14 23:52 ` [PATCH 2/4] MIPS: Add syscall detection " Paul Burton
2018-06-14 23:52 ` Paul Burton
2018-06-15 17:41 ` Mathieu Desnoyers
2018-06-15 18:43 ` Paul Burton
2018-06-16 20:28 ` Mathieu Desnoyers
2018-06-14 23:52 ` [PATCH 3/4] MIPS: Wire up the restartable sequences (rseq) syscall Paul Burton
2018-06-14 23:52 ` Paul Burton
2018-06-14 23:52 ` [PATCH 4/4] rseq/selftests: Implement MIPS support Paul Burton
2018-06-14 23:52 ` Paul Burton
2018-06-15 10:58 ` James Hogan
2018-06-15 17:37 ` Mathieu Desnoyers [this message]
2018-06-15 18:16 ` Paul Burton
2018-06-15 18:16 ` Paul Burton
2018-06-16 20:24 ` [PATCH 0/4] MIPS: Restartable sequences (rseq) support Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373980460.14412.1529084239034.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=boqun.feng@gmail.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.