From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 5/5] powerpc: using reset hcall when kvm,has-reset Date: Tue, 16 Jul 2013 18:26:40 -0500 Message-ID: <1374017200.8183.346@snotra> References: <1373927035.8183.318@snotra> <467C55E3-C05F-4B42-BC6D-00F7719E3D72@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Bhushan Bharat-R65777 , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" , Wood Scott-B07421 , Yoder Stuart-B08248 To: Alexander Graf Return-path: In-Reply-To: <467C55E3-C05F-4B42-BC6D-00F7719E3D72@suse.de> (from agraf@suse.de on Tue Jul 16 18:21:51 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/16/2013 06:21:51 PM, Alexander Graf wrote: > > On 16.07.2013, at 00:23, Scott Wood wrote: > > > Still, I'm not sure what sort of error you're thinking of. If the > guest didn't support the hcall mechanism we would have returned from > the function by that point. In fact, seeing kvm,has-reset on a > different hypervisor ought to mean that that hypervisor is emulating > KVM in this particular respect. > > Imagine we're running on KVM with this reset hcall support. Now if > the guest has CONFIG_EPAPR_PARAVIRT enabled but CONFIG_KVM_GUEST > disabled, we would patch the callback, but kvm_hypercall0() would be > implemented as a nop. Ugh -- that should be renamed epapr_hypercall and moved to epapr_paravirt.c. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 16 Jul 2013 23:26:40 +0000 Subject: Re: [PATCH 5/5] powerpc: using reset hcall when kvm,has-reset Message-Id: <1374017200.8183.346@snotra> List-Id: References: <1373927035.8183.318@snotra> <467C55E3-C05F-4B42-BC6D-00F7719E3D72@suse.de> In-Reply-To: <467C55E3-C05F-4B42-BC6D-00F7719E3D72@suse.de> (from agraf@suse.de on Tue Jul 16 18:21:51 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Bhushan Bharat-R65777 , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" , Wood Scott-B07421 , Yoder Stuart-B08248 On 07/16/2013 06:21:51 PM, Alexander Graf wrote: > > On 16.07.2013, at 00:23, Scott Wood wrote: > > > Still, I'm not sure what sort of error you're thinking of. If the > guest didn't support the hcall mechanism we would have returned from > the function by that point. In fact, seeing kvm,has-reset on a > different hypervisor ought to mean that that hypervisor is emulating > KVM in this particular respect. > > Imagine we're running on KVM with this reset hcall support. Now if > the guest has CONFIG_EPAPR_PARAVIRT enabled but CONFIG_KVM_GUEST > disabled, we would patch the callback, but kvm_hypercall0() would be > implemented as a nop. Ugh -- that should be renamed epapr_hypercall and moved to epapr_paravirt.c. -Scott