Re: [PATCH -tip 0/3] kprobes, x86: Move optprobe on top of int3-based instruction patching

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 2013-07-18 at 20:47 +0900, Masami Hiramatsu wrote:
> Hi,
> 
> Here is a series of kprobes and x86 patches for moving
> optprobe (jump optimized kprobe) onto the int3-based
> instruction patching (a.k.a. text_poke_bp, introduced by
> Jiri Kosina).
> 
> Since this completely moves text_poke_smp* user to new
> text_poke_bp, I also remove the old text_poke_smp* code
> from alternative.c. As a side effect, it also fixes a
> Kconfig warning about CONFIG_STOP_MACHINE dependency
> confliction.
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (3):
>       [CLEANUP] kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE
>       kprobes/x86: Use text_poke_bp() instead of text_poke_smp*()
>       x86: Remove unused text_poke_smp and text_poke_smp_batch

Nice work Masami!

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> 
> 
>  arch/x86/Kconfig                   |    5 --
>  arch/x86/include/asm/alternative.h |   11 ----
>  arch/x86/kernel/alternative.c      |   98 +-------------------------------
>  arch/x86/kernel/kprobes/common.h   |    5 --
>  arch/x86/kernel/kprobes/core.c     |    2 -
>  arch/x86/kernel/kprobes/opt.c      |  110 +++++++-----------------------------
>  6 files changed, 25 insertions(+), 206 deletions(-)
>