All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 02/11] perf evsel: Handle ENODEV on default cycles event
Date: Mon, 22 Jul 2013 17:22:30 -0300	[thread overview]
Message-ID: <1374524559-9839-3-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1374524559-9839-1-git-send-email-acme@infradead.org>

From: David Ahern <dsahern@gmail.com>

Some systems (e.g., VMs on qemu-0.13 with the default vcpu model) report
an unsupported CPU model:

Performance Events: unsupported p6 CPU model 2 no PMU driver, software events only.

Subsequent invocations of perf fail with:

The sys_perf_event_open() syscall returned with 19 (No such device) for event (cycles).
/bin/dmesg may provide additional information.
No CONFIG_PERF_EVENTS=y kernel support configured?

Add ENODEV to the list of errno's to fallback to cpu-clock.

Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1374190079-28507-1-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index a635461..8bed0c1 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1482,7 +1482,7 @@ out:
 bool perf_evsel__fallback(struct perf_evsel *evsel, int err,
 			  char *msg, size_t msgsize)
 {
-	if ((err == ENOENT || err == ENXIO) &&
+	if ((err == ENOENT || err == ENXIO || err == ENODEV) &&
 	    evsel->attr.type   == PERF_TYPE_HARDWARE &&
 	    evsel->attr.config == PERF_COUNT_HW_CPU_CYCLES) {
 		/*
-- 
1.8.1.4


  parent reply	other threads:[~2013-07-22 20:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 20:22 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 01/11] perf script: Fix named threads support Arnaldo Carvalho de Melo
2013-07-22 20:22 ` Arnaldo Carvalho de Melo [this message]
2013-07-22 20:22 ` [PATCH 03/11] perf bench: Fix memcpy benchmark for large sizes Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 04/11] perf tools: Support callchain sorting based on addresses Arnaldo Carvalho de Melo
2013-07-22 20:33   ` Frederic Weisbecker
2013-07-22 20:22 ` [PATCH 05/11] perf tools: Fix build with perl 5.18 Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 06/11] perf tests: Run ctags/cscope make tests only with needed binaries Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 07/11] perf tests: Rename TMP to TMP_O tests/make variable Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 08/11] perf tests: Add DESTDIR=TMP_DEST " Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 09/11] perf tests: Add 'make install/install-bin' tests into tests/make Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 10/11] perf tests: Add broken install-* " Arnaldo Carvalho de Melo
2013-07-22 20:22 ` [PATCH 11/11] perf tools: Move weight back to common sort keys Arnaldo Carvalho de Melo
2013-07-23  7:38 ` [GIT PULL 00/11] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374524559-9839-3-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.