All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: "Lan Yixun (dlan)" <dennis.yxun@gmail.com>
Cc: autofs@vger.kernel.org
Subject: Re: [PATCH 4/6] fix no "libxml/tree.h" error in modules lookup_ldap.c
Date: Tue, 23 Jul 2013 18:17:38 +0800	[thread overview]
Message-ID: <1374574658.3418.7.camel@perseus.fritz.box> (raw)
In-Reply-To: <1374505194-22668-5-git-send-email-dennis.yxun@gmail.com>

On Mon, 2013-07-22 at 22:59 +0800, Lan Yixun (dlan) wrote:
> From: "Lan Yixun (dlan)" <dennis.yxun@gmail.com>
> 
> make "libxml/tree.h" controlled by WITH_SASL, also move it beind line of
> #include "automount.h", since WITH_SASL is defined in config.h which is
> included by automout.h

Same again, WITH_LDAP defined and WITH_SASL not.
I agree there appears to be a problem but not sure what to do about it.

> 
> ---
> Gentoo Bugs:
>  https://bugs.gentoo.org/show_bug.cgi?id=468606
> 
> gcc -shared -O2 -pipe -march=core2  -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT
> -D_FILE_OFFSET_BITS=
> 64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\"
> -DAUTOFS_MAP_DIR=\"/e
> tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \
>         lookup_ldap.c dclist.o base64.o  \
>         ../lib/autofs.a -lldap -llber -lresolv
> : lookup_yp.so
> lookup_ldap.c:31:25: fatal error: libxml/tree.h: No such file or directory
>  #include <libxml/tree.h>
>                          ^
> compilation terminated.
> 
> Signed-off-by: Lan Yixun (dlan) <dennis.yxun@gmail.com>
> ---
>  modules/lookup_ldap.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/modules/lookup_ldap.c b/modules/lookup_ldap.c
> index b8970a6..fad558d 100644
> --- a/modules/lookup_ldap.c
> +++ b/modules/lookup_ldap.c
> @@ -28,7 +28,6 @@
>  #include <arpa/nameser.h>
>  #include <resolv.h>
>  #include <lber.h>
> -#include <libxml/tree.h>
>  
>  #define MODULE_LOOKUP
>  #include "automount.h"
> @@ -36,6 +35,10 @@
>  #include "lookup_ldap.h"
>  #include "base64.h"
>  
> +#ifdef WITH_SASL
> +#include <libxml/tree.h>
> +#endif
> +
>  #define MAPFMT_DEFAULT "sun"
>  
>  #define MODPREFIX "lookup(ldap): "



  reply	other threads:[~2013-07-23 10:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 14:59 Seeking for upstreaming patches which floating in Gentoo Lan Yixun (dlan)
2013-07-22 14:59 ` [PATCH 1/6] fix compile error with heimdal support enabled Lan Yixun (dlan)
2013-07-23  9:44   ` Ian Kent
2013-07-23 10:19     ` Dennis Lan (dlan)
2013-07-23 10:50       ` Ian Kent
2013-07-24 10:25         ` Dennis Lan (dlan)
2013-07-24 10:32           ` Ian Kent
2013-07-22 14:59 ` [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled Lan Yixun (dlan)
2013-07-23  9:50   ` Ian Kent
2013-07-23 10:10     ` Ian Kent
2013-07-23 10:30       ` Dennis Lan (dlan)
2013-07-23 10:39         ` Ian Kent
2013-07-24  2:13         ` Ian Kent
2013-07-24  2:24           ` Dennis Lan (dlan)
2013-07-22 14:59 ` [PATCH 3/6] fix compile error with LDAP enabled but SASL disabled Lan Yixun (dlan)
2013-07-22 14:59 ` [PATCH 4/6] fix no "libxml/tree.h" error in modules lookup_ldap.c Lan Yixun (dlan)
2013-07-23 10:17   ` Ian Kent [this message]
2013-07-23 10:37     ` Dennis Lan (dlan)
2013-07-23 10:42       ` Ian Kent
2013-07-23 10:49         ` Dennis Lan (dlan)
2013-07-22 14:59 ` [PATCH 5/6] add missing WITH_SASL " Lan Yixun (dlan)
2013-07-23 10:35   ` Ian Kent
2013-07-23 10:47     ` Dennis Lan (dlan)
2013-07-22 14:59 ` [PATCH 6/6] fix typo, forced-shutdown should be force-shutdown Lan Yixun (dlan)
2013-07-23 10:37   ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374574658.3418.7.camel@perseus.fritz.box \
    --to=raven@themaw.net \
    --cc=autofs@vger.kernel.org \
    --cc=dennis.yxun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.