* [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC
@ 2013-07-30 11:19 Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Vikas Sajjan
` (7 more replies)
0 siblings, 8 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
This patchset adds DT nodes for FIMD and DP controller for Exynos5420
based SMDK.
It moves all common properties of FIMD and DP controller DT node specific to
Exynos5 Socs like 5250 and 5420 to exynos5.dtsi file.
It also adds required PM domain DT nodes for exynos5420.
Is rebased on branch kgene's "for-next"
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/?h=for-next
The DP PHY DT Node is based on Jingoo Han's inflight patchset at
http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/66435
changes since v1:
- Addressed comments given by Tomasz Figa <tomasz.figa@gmail.com>
and Ajay kumar <ajaynumb@gmail.com>
Vikas Sajjan (6):
ARM: dts: Move display-timimg information inside FIMD DT node for
exynos5250
ARM: dts: Update FIMD DT node for Exynos5 SoCs
ARM: dts: Add FIMD DT node to exynos5420 DTS files
ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
ARM: dts: Add DP controller DT node to exynos5420 SoC
ARM: dts: Add pin state information for DP HPD support to Exynos5420
Yadwinder Singh Brar (1):
ARM: dts: Add basic PM domains for EXYNOS5420
arch/arm/boot/dts/exynos5.dtsi | 21 +++++++++++
arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 32 +++++++++--------
arch/arm/boot/dts/exynos5250.dtsi | 28 ++++++---------
arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 ++++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 31 ++++++++++++++++
arch/arm/boot/dts/exynos5420.dtsi | 55 +++++++++++++++++++++++++++++
7 files changed, 145 insertions(+), 33 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-08-01 14:49 ` Tomasz Figa
2013-07-30 11:19 ` [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs Vikas Sajjan
` (6 subsequent siblings)
7 siblings, 1 reply; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
As the display-timing information is parsed by FIMD driver, it makes
sense to move the display-timimg DT node inside FIMD DT node for exynos5250
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 29 ++++++++++++++++-------------
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 49f18c2..d176dbb 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -262,19 +262,22 @@
pinctrl-0 = <&dp_hpd>;
};
- display-timings {
- native-mode = <&timing0>;
- timing0: timing@0 {
- /* 1280x800 */
- clock-frequency = <50000>;
- hactive = <1280>;
- vactive = <800>;
- hfront-porch = <4>;
- hback-porch = <4>;
- hsync-len = <4>;
- vback-porch = <4>;
- vfront-porch = <4>;
- vsync-len = <4>;
+ fimd@14400000 {
+ status = "okay";
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing@0 {
+ /* 1280x800 */
+ clock-frequency = <50000>;
+ hactive = <1280>;
+ vactive = <800>;
+ hfront-porch = <4>;
+ hback-porch = <4>;
+ hsync-len = <4>;
+ vback-porch = <4>;
+ vfront-porch = <4>;
+ vsync-len = <4>;
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-08-14 7:33 ` Kukjin Kim
2013-07-30 11:19 ` [PATCH v2 3/7] ARM: dts: Add basic PM domains for EXYNOS5420 Vikas Sajjan
` (5 subsequent siblings)
7 siblings, 1 reply; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
Moves the properties of FIMD DT node which are common across Exynos5 based
SoCs like Exynos5250 and Exxynos5420 to exynos5.dtsi
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos5.dtsi | 10 ++++++++++
arch/arm/boot/dts/exynos5250-arndale.dts | 1 +
arch/arm/boot/dts/exynos5250.dtsi | 7 +------
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index f65e124..d464b6c 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -108,4 +108,14 @@
interrupts = <0 42 0>;
status = "disabled";
};
+
+ fimd@14400000 {
+ compatible = "samsung,exynos5250-fimd";
+ interrupt-parent = <&combiner>;
+ reg = <0x14400000 0x40000>;
+ interrupt-names = "fifo", "vsync", "lcd_sys";
+ interrupts = <18 4>, <18 5>, <18 6>;
+ status = "disabled";
+ };
+
};
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 96d528d..76825ef 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -519,6 +519,7 @@
};
fimd: fimd@14400000 {
+ status = "okay";
display-timings {
native-mode = <&timing0>;
timing0: timing@0 {
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..238bdb2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -630,12 +630,7 @@
};
};
- fimd {
- compatible = "samsung,exynos5250-fimd";
- interrupt-parent = <&combiner>;
- reg = <0x14400000 0x40000>;
- interrupt-names = "fifo", "vsync", "lcd_sys";
- interrupts = <18 4>, <18 5>, <18 6>;
+ fimd@14400000 {
clocks = <&clock 133>, <&clock 339>;
clock-names = "sclk_fimd", "fimd";
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 3/7] ARM: dts: Add basic PM domains for EXYNOS5420
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 4/7] ARM: dts: Add FIMD DT node to exynos5420 DTS files Vikas Sajjan
` (4 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
From: Yadwinder Singh Brar <yadi.brar@samsung.com>
Add DT nodes for gsc, isp, mfc, disp, mau, g2d and msc PM domains.
Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 8c54c4b..884d8f4 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -90,6 +90,41 @@
};
};
+ gsc_pd: power-domain@10044000 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10044000 0x20>;
+ };
+
+ isp_pd: power-domain@10044020 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10044020 0x20>;
+ };
+
+ mfc_pd: power-domain@10044060 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10044060 0x20>;
+ };
+
+ disp_pd: power-domain@100440C0 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x100440C0 0x20>;
+ };
+
+ mau_pd: power-domain@100440E0 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x100440E0 0x20>;
+ };
+
+ g2d_pd: power-domain@10044100 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10044100 0x20>;
+ };
+
+ msc_pd: power-domain@10044120 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10044120 0x20>;
+ };
+
pinctrl_0: pinctrl@13400000 {
compatible = "samsung,exynos5420-pinctrl";
reg = <0x13400000 0x1000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 4/7] ARM: dts: Add FIMD DT node to exynos5420 DTS files
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
` (2 preceding siblings ...)
2013-07-30 11:19 ` [PATCH v2 3/7] ARM: dts: Add basic PM domains for EXYNOS5420 Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs Vikas Sajjan
` (3 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
Adds FIMD DT node to exynos5420 based SMDK. Also adds display-timimg
information node.
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 19 +++++++++++++++++++
arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
2 files changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 08607df..0c0249c 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -30,4 +30,23 @@
clock-frequency = <24000000>;
};
};
+
+ fimd@14400000 {
+ status = "okay";
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing@0 {
+ clock-frequency = <50000>;
+ hactive = <2560>;
+ vactive = <1600>;
+ hfront-porch = <48>;
+ hback-porch = <80>;
+ hsync-len = <32>;
+ vback-porch = <16>;
+ vfront-porch = <8>;
+ vsync-len = <6>;
+ };
+ };
+ };
+
};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 884d8f4..2f98c89 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -180,4 +180,11 @@
clocks = <&clock 260>, <&clock 131>;
clock-names = "uart", "clk_uart_baud0";
};
+
+ fimd@14400000 {
+ samsung,power-domain = <&disp_pd>;
+ clocks = <&clock 147>, <&clock 421>;
+ clock-names = "sclk_fimd", "fimd";
+ };
+
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
` (3 preceding siblings ...)
2013-07-30 11:19 ` [PATCH v2 4/7] ARM: dts: Add FIMD DT node to exynos5420 DTS files Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-08-26 2:57 ` Jingoo Han
2013-07-30 11:19 ` [PATCH v2 6/7] ARM: dts: Add DP controller DT node to exynos5420 SoC Vikas Sajjan
` (2 subsequent siblings)
7 siblings, 1 reply; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
Moves the properties of DP controller to exynos5.dtsi which are common
across exynos5 SoCs like Exynos5250 and Exynos5420.
The PHY DP Node is based on Jingoo Han's <jg1.han@samsung.com> patch at
https://patchwork.linuxtv.org/patch/19189/
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos5.dtsi | 11 +++++++++++
arch/arm/boot/dts/exynos5250-arndale.dts | 3 ++-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 ++-
arch/arm/boot/dts/exynos5250.dtsi | 21 +++++++++------------
4 files changed, 24 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index d464b6c..213a2d8 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -118,4 +118,15 @@
status = "disabled";
};
+ dp-controller@145b0000 {
+ compatible = "samsung,exynos5-dp";
+ reg = <0x145b0000 0x1000>;
+ interrupts = <10 3>;
+ interrupt-parent = <&combiner>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+
};
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 76825ef..ce74400 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -509,13 +509,14 @@
};
};
- dp-controller {
+ dp-controller@145b0000 {
samsung,color-space = <0>;
samsung,dynamic-range = <0>;
samsung,ycbcr-coeff = <0>;
samsung,color-depth = <1>;
samsung,link-rate = <0x0a>;
samsung,lane-count = <4>;
+ status = "okay";
};
fimd: fimd@14400000 {
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index d176dbb..f9ab99c 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -250,7 +250,7 @@
samsung,vbus-gpio = <&gpx2 6 0>;
};
- dp-controller {
+ dp-controller@145b0000 {
samsung,color-space = <0>;
samsung,dynamic-range = <0>;
samsung,ycbcr-coeff = <0>;
@@ -260,6 +260,7 @@
pinctrl-names = "default";
pinctrl-0 = <&dp_hpd>;
+ status = "okay";
};
fimd@14400000 {
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 238bdb2..1c017dc 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -614,20 +614,17 @@
interrupts = <0 94 0>;
};
- dp-controller {
- compatible = "samsung,exynos5-dp";
- reg = <0x145b0000 0x1000>;
- interrupts = <10 3>;
- interrupt-parent = <&combiner>;
+ dp_phy: video-phy@10040720 {
+ compatible = "samsung,exynos5250-dp-video-phy";
+ reg = <0x10040720 4>;
+ #phy-cells = <0>;
+ };
+
+ dp-controller@145b0000 {
clocks = <&clock 342>;
clock-names = "dp";
- #address-cells = <1>;
- #size-cells = <0>;
-
- dptx-phy {
- reg = <0x10040720>;
- samsung,enable-mask = <1>;
- };
+ phys = <&dp_phy>;
+ phy-names = "dp";
};
fimd@14400000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 6/7] ARM: dts: Add DP controller DT node to exynos5420 SoC
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
` (4 preceding siblings ...)
2013-07-30 11:19 ` [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 7/7] ARM: dts: Add pin state information for DP HPD support to Exynos5420 Vikas Sajjan
2013-08-14 5:58 ` [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Kukjin Kim
7 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
Adds DP controller DT node to exynos5420 SoC
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 ++++++++++
arch/arm/boot/dts/exynos5420.dtsi | 13 +++++++++++++
2 files changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 0c0249c..80aa3d4 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,16 @@
};
};
+ dp-controller@145b0000 {
+ samsung,color-space = <0>;
+ samsung,dynamic-range = <0>;
+ samsung,ycbcr-coeff = <0>;
+ samsung,color-depth = <1>;
+ samsung,link-rate = <0x0a>;
+ samsung,lane-count = <4>;
+ status = "okay";
+ };
+
fimd@14400000 {
status = "okay";
display-timings {
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 2f98c89..8255db2 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -181,6 +181,19 @@
clock-names = "uart", "clk_uart_baud0";
};
+ dp_phy: video-phy@10040728 {
+ compatible = "samsung,exynos5250-dp-video-phy";
+ reg = <0x10040728 4>;
+ #phy-cells = <0>;
+ };
+
+ dp-controller@145b0000 {
+ clocks = <&clock 412>;
+ clock-names = "dp";
+ phys = <&dp_phy>;
+ phy-names = "dp";
+ };
+
fimd@14400000 {
samsung,power-domain = <&disp_pd>;
clocks = <&clock 147>, <&clock 421>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 7/7] ARM: dts: Add pin state information for DP HPD support to Exynos5420
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
` (5 preceding siblings ...)
2013-07-30 11:19 ` [PATCH v2 6/7] ARM: dts: Add DP controller DT node to exynos5420 SoC Vikas Sajjan
@ 2013-07-30 11:19 ` Vikas Sajjan
2013-08-14 5:58 ` [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Kukjin Kim
7 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-07-30 11:19 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel
Add pin state information for DP HPD support that requires pin configuration
support using pinctrl interface.
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 ++
2 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index 5848c42..e695aba 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -59,6 +59,13 @@
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ dp_hpd: dp_hpd {
+ samsung,pins = "gpx0-7";
+ samsung,pin-function = <3>;
+ samsung,pin-pud = <0>;
+ samaung,pin-drv = <0>;
+ };
};
pinctrl@13410000 {
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 80aa3d4..123e523 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -32,6 +32,8 @@
};
dp-controller@145b0000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&dp_hpd>;
samsung,color-space = <0>;
samsung,dynamic-range = <0>;
samsung,ycbcr-coeff = <0>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-07-30 11:19 ` [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Vikas Sajjan
@ 2013-08-01 14:49 ` Tomasz Figa
2013-08-05 10:04 ` Vikas Sajjan
2013-08-14 5:56 ` Kukjin Kim
0 siblings, 2 replies; 23+ messages in thread
From: Tomasz Figa @ 2013-08-01 14:49 UTC (permalink / raw)
To: Vikas Sajjan
Cc: linux-samsung-soc, kgene.kim, devicetree, jg1.han, inki.dae,
ajaynumb, patches, linaro-kernel, grant.likely, swarren,
mark.rutland
Hi Vikas,
On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
> As the display-timing information is parsed by FIMD driver, it makes
> sense to move the display-timimg DT node inside FIMD DT node for
> exynos5250
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
> ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
> deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
> 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -262,19 +262,22 @@
> pinctrl-0 = <&dp_hpd>;
> };
>
> - display-timings {
> - native-mode = <&timing0>;
> - timing0: timing@0 {
> - /* 1280x800 */
> - clock-frequency = <50000>;
> - hactive = <1280>;
> - vactive = <800>;
> - hfront-porch = <4>;
> - hback-porch = <4>;
> - hsync-len = <4>;
> - vback-porch = <4>;
> - vfront-porch = <4>;
> - vsync-len = <4>;
> + fimd@14400000 {
> + status = "okay";
> + display-timings {
> + native-mode = <&timing0>;
> + timing0: timing@0 {
> + /* 1280x800 */
> + clock-frequency = <50000>;
> + hactive = <1280>;
> + vactive = <800>;
> + hfront-porch = <4>;
> + hback-porch = <4>;
> + hsync-len = <4>;
> + vback-porch = <4>;
> + vfront-porch = <4>;
> + vsync-len = <4>;
> + };
> };
> };
Looks good to me, but I would like some other people from the device tree
mailing list to comment on node naming: Do we want to conform to the
recommendation of ePAPR about node naming, which states that node names
should be generic, not platform specific or we are free to ignore it?
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-08-01 14:49 ` Tomasz Figa
@ 2013-08-05 10:04 ` Vikas Sajjan
2013-08-05 10:29 ` Sachin Kamat
2013-08-14 5:56 ` Kukjin Kim
1 sibling, 1 reply; 23+ messages in thread
From: Vikas Sajjan @ 2013-08-05 10:04 UTC (permalink / raw)
To: Tomasz Figa
Cc: Vikas Sajjan, linux-samsung-soc, Kukjin Kim, devicetree,
Jingoo Han, InKi Dae, ajaynumb, patches, linaro-kernel,
grant.likely, Sylwester Nawrocki
Hi All,
On Thu, Aug 1, 2013 at 8:19 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Vikas,
>
> On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
>> As the display-timing information is parsed by FIMD driver, it makes
>> sense to move the display-timimg DT node inside FIMD DT node for
>> exynos5250
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
>> ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
>> deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
>> 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -262,19 +262,22 @@
>> pinctrl-0 = <&dp_hpd>;
>> };
>>
>> - display-timings {
>> - native-mode = <&timing0>;
>> - timing0: timing@0 {
>> - /* 1280x800 */
>> - clock-frequency = <50000>;
>> - hactive = <1280>;
>> - vactive = <800>;
>> - hfront-porch = <4>;
>> - hback-porch = <4>;
>> - hsync-len = <4>;
>> - vback-porch = <4>;
>> - vfront-porch = <4>;
>> - vsync-len = <4>;
>> + fimd@14400000 {
>> + status = "okay";
>> + display-timings {
>> + native-mode = <&timing0>;
>> + timing0: timing@0 {
>> + /* 1280x800 */
>> + clock-frequency = <50000>;
>> + hactive = <1280>;
>> + vactive = <800>;
>> + hfront-porch = <4>;
>> + hback-porch = <4>;
>> + hsync-len = <4>;
>> + vback-porch = <4>;
>> + vfront-porch = <4>;
>> + vsync-len = <4>;
>> + };
>> };
>> };
>
> Looks good to me, but I would like some other people from the device tree
> mailing list to comment on node naming: Do we want to conform to the
> recommendation of ePAPR about node naming, which states that node names
> should be generic, not platform specific or we are free to ignore it?
>
Any more comments on this series.
> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-08-05 10:04 ` Vikas Sajjan
@ 2013-08-05 10:29 ` Sachin Kamat
2013-08-12 6:57 ` Vikas Sajjan
0 siblings, 1 reply; 23+ messages in thread
From: Sachin Kamat @ 2013-08-05 10:29 UTC (permalink / raw)
To: Vikas Sajjan
Cc: Tomasz Figa, Vikas Sajjan, linux-samsung-soc, Kukjin Kim,
devicetree, Jingoo Han, InKi Dae, ajaynumb, patches,
linaro-kernel, grant.likely, Sylwester Nawrocki
On 5 August 2013 15:34, Vikas Sajjan <sajjan.linux@gmail.com> wrote:
> Hi All,
>
> On Thu, Aug 1, 2013 at 8:19 PM, Tomasz Figa <t.figa@samsung.com> wrote:
>> Hi Vikas,
>>
>> On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
>>> As the display-timing information is parsed by FIMD driver, it makes
>>> sense to move the display-timimg DT node inside FIMD DT node for
>>> exynos5250
>>>
>>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>>> ---
>>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
>>> ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
>>> deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
>>> 100644
>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> @@ -262,19 +262,22 @@
>>> pinctrl-0 = <&dp_hpd>;
>>> };
>>>
>>> - display-timings {
>>> - native-mode = <&timing0>;
>>> - timing0: timing@0 {
>>> - /* 1280x800 */
>>> - clock-frequency = <50000>;
>>> - hactive = <1280>;
>>> - vactive = <800>;
>>> - hfront-porch = <4>;
>>> - hback-porch = <4>;
>>> - hsync-len = <4>;
>>> - vback-porch = <4>;
>>> - vfront-porch = <4>;
>>> - vsync-len = <4>;
>>> + fimd@14400000 {
>>> + status = "okay";
>>> + display-timings {
>>> + native-mode = <&timing0>;
>>> + timing0: timing@0 {
>>> + /* 1280x800 */
>>> + clock-frequency = <50000>;
>>> + hactive = <1280>;
>>> + vactive = <800>;
>>> + hfront-porch = <4>;
>>> + hback-porch = <4>;
>>> + hsync-len = <4>;
>>> + vback-porch = <4>;
>>> + vfront-porch = <4>;
>>> + vsync-len = <4>;
>>> + };
>>> };
>>> };
>>
>> Looks good to me, but I would like some other people from the device tree
>> mailing list to comment on node naming: Do we want to conform to the
>> recommendation of ePAPR about node naming, which states that node names
>> should be generic, not platform specific or we are free to ignore it?
>>
>
> Any more comments on this series.
One trivial typo in patch subject and commit message:
s/timimg/timing
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-08-05 10:29 ` Sachin Kamat
@ 2013-08-12 6:57 ` Vikas Sajjan
0 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-08-12 6:57 UTC (permalink / raw)
To: Kukjin Kim
Cc: Tomasz Figa, Vikas Sajjan, linux-samsung-soc, devicetree,
Jingoo Han, InKi Dae, ajaynumb, patches, linaro-kernel,
grant.likely, Sylwester Nawrocki, sunil joshi
Hi Kukjin,
On Mon, Aug 5, 2013 at 3:59 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 5 August 2013 15:34, Vikas Sajjan <sajjan.linux@gmail.com> wrote:
>> Hi All,
>>
>> On Thu, Aug 1, 2013 at 8:19 PM, Tomasz Figa <t.figa@samsung.com> wrote:
>>> Hi Vikas,
>>>
>>> On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
>>>> As the display-timing information is parsed by FIMD driver, it makes
>>>> sense to move the display-timimg DT node inside FIMD DT node for
>>>> exynos5250
>>>>
>>>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>>>> ---
>>>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
>>>> ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
>>>> deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
>>>> 100644
>>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> @@ -262,19 +262,22 @@
>>>> pinctrl-0 = <&dp_hpd>;
>>>> };
>>>>
>>>> - display-timings {
>>>> - native-mode = <&timing0>;
>>>> - timing0: timing@0 {
>>>> - /* 1280x800 */
>>>> - clock-frequency = <50000>;
>>>> - hactive = <1280>;
>>>> - vactive = <800>;
>>>> - hfront-porch = <4>;
>>>> - hback-porch = <4>;
>>>> - hsync-len = <4>;
>>>> - vback-porch = <4>;
>>>> - vfront-porch = <4>;
>>>> - vsync-len = <4>;
>>>> + fimd@14400000 {
>>>> + status = "okay";
>>>> + display-timings {
>>>> + native-mode = <&timing0>;
>>>> + timing0: timing@0 {
>>>> + /* 1280x800 */
>>>> + clock-frequency = <50000>;
>>>> + hactive = <1280>;
>>>> + vactive = <800>;
>>>> + hfront-porch = <4>;
>>>> + hback-porch = <4>;
>>>> + hsync-len = <4>;
>>>> + vback-porch = <4>;
>>>> + vfront-porch = <4>;
>>>> + vsync-len = <4>;
>>>> + };
>>>> };
>>>> };
>>>
>>> Looks good to me, but I would like some other people from the device tree
>>> mailing list to comment on node naming: Do we want to conform to the
>>> recommendation of ePAPR about node naming, which states that node names
>>> should be generic, not platform specific or we are free to ignore it?
>>>
>>
>> Any more comments on this series.
>
> One trivial typo in patch subject and commit message:
> s/timimg/timing
>
Can you apply this series (by correcting typo s/timimg/timing) OR you
want me to respin V3 with this typo correction.
>
>
> --
> With warm regards,
> Sachin
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-08-01 14:49 ` Tomasz Figa
2013-08-05 10:04 ` Vikas Sajjan
@ 2013-08-14 5:56 ` Kukjin Kim
2013-08-14 8:16 ` Tomasz Figa
1 sibling, 1 reply; 23+ messages in thread
From: Kukjin Kim @ 2013-08-14 5:56 UTC (permalink / raw)
To: 'Tomasz Figa', 'Vikas Sajjan'
Cc: linux-samsung-soc, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel, grant.likely, swarren, mark.rutland
Tomasz Figa wrote:
>
> Hi Vikas,
>
> On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
> > As the display-timing information is parsed by FIMD driver, it makes
> > sense to move the display-timimg DT node inside FIMD DT node for
> > exynos5250
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> > ---
> > arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
> > ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
> > deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
> > 100644
> > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > @@ -262,19 +262,22 @@
> > pinctrl-0 = <&dp_hpd>;
> > };
> >
> > - display-timings {
> > - native-mode = <&timing0>;
> > - timing0: timing@0 {
> > - /* 1280x800 */
> > - clock-frequency = <50000>;
> > - hactive = <1280>;
> > - vactive = <800>;
> > - hfront-porch = <4>;
> > - hback-porch = <4>;
> > - hsync-len = <4>;
> > - vback-porch = <4>;
> > - vfront-porch = <4>;
> > - vsync-len = <4>;
> > + fimd@14400000 {
> > + status = "okay";
> > + display-timings {
> > + native-mode = <&timing0>;
> > + timing0: timing@0 {
> > + /* 1280x800 */
> > + clock-frequency = <50000>;
> > + hactive = <1280>;
> > + vactive = <800>;
> > + hfront-porch = <4>;
> > + hback-porch = <4>;
> > + hsync-len = <4>;
> > + vback-porch = <4>;
> > + vfront-porch = <4>;
> > + vsync-len = <4>;
> > + };
> > };
> > };
>
> Looks good to me, but I would like some other people from the device tree
> mailing list to comment on node naming: Do we want to conform to the
> recommendation of ePAPR about node naming, which states that node names
> should be generic, not platform specific or we are free to ignore it?
>
The name of node looks good to me and the name had been being used for a
long time, and if we change that now, that will cause the bigger confusion.
- Kukjin
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
` (6 preceding siblings ...)
2013-07-30 11:19 ` [PATCH v2 7/7] ARM: dts: Add pin state information for DP HPD support to Exynos5420 Vikas Sajjan
@ 2013-08-14 5:58 ` Kukjin Kim
2013-08-14 6:00 ` Vikas Sajjan
7 siblings, 1 reply; 23+ messages in thread
From: Kukjin Kim @ 2013-08-14 5:58 UTC (permalink / raw)
To: 'Vikas Sajjan', linux-samsung-soc
Cc: t.figa, devicetree, jg1.han, inki.dae, ajaynumb, patches, linaro-kernel
Vikas Sajjan wrote:
>
> This patchset adds DT nodes for FIMD and DP controller for Exynos5420
> based SMDK.
>
> It moves all common properties of FIMD and DP controller DT node specific
> to
> Exynos5 Socs like 5250 and 5420 to exynos5.dtsi file.
>
> It also adds required PM domain DT nodes for exynos5420.
>
> Is rebased on branch kgene's "for-next"
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-
> samsung.git/log/?h=for-next
>
> The DP PHY DT Node is based on Jingoo Han's inflight patchset at
> http://comments.gmane.org/gmane.linux.drivers.video-input-
> infrastructure/66435
>
> changes since v1:
> - Addressed comments given by Tomasz Figa <tomasz.figa@gmail.com>
> and Ajay kumar <ajaynumb@gmail.com>
>
> Vikas Sajjan (6):
> ARM: dts: Move display-timimg information inside FIMD DT node for
> exynos5250
> ARM: dts: Update FIMD DT node for Exynos5 SoCs
> ARM: dts: Add FIMD DT node to exynos5420 DTS files
> ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
> ARM: dts: Add DP controller DT node to exynos5420 SoC
> ARM: dts: Add pin state information for DP HPD support to Exynos5420
>
> Yadwinder Singh Brar (1):
> ARM: dts: Add basic PM domains for EXYNOS5420
>
> arch/arm/boot/dts/exynos5.dtsi | 21 +++++++++++
> arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++-
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 32 +++++++++--------
> arch/arm/boot/dts/exynos5250.dtsi | 28 ++++++---------
> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 ++++
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 31 ++++++++++++++++
> arch/arm/boot/dts/exynos5420.dtsi | 55
> +++++++++++++++++++++++++++++
> 7 files changed, 145 insertions(+), 33 deletions(-)
>
> --
> 1.7.9.5
Looks good to me, will apply this whole series with fix typo, timimg? ;-)
- Kukjin
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC
2013-08-14 5:58 ` [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Kukjin Kim
@ 2013-08-14 6:00 ` Vikas Sajjan
0 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-08-14 6:00 UTC (permalink / raw)
To: Kukjin Kim
Cc: Vikas Sajjan, linux-samsung-soc, Tomasz Figa, devicetree,
Jingoo Han, InKi Dae, Ajay kumar, patches, linaro-kernel
Hi Kukjin,
On Wed, Aug 14, 2013 at 11:28 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Vikas Sajjan wrote:
>>
>> This patchset adds DT nodes for FIMD and DP controller for Exynos5420
>> based SMDK.
>>
>> It moves all common properties of FIMD and DP controller DT node specific
>> to
>> Exynos5 Socs like 5250 and 5420 to exynos5.dtsi file.
>>
>> It also adds required PM domain DT nodes for exynos5420.
>>
>> Is rebased on branch kgene's "for-next"
>> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-
>> samsung.git/log/?h=for-next
>>
>> The DP PHY DT Node is based on Jingoo Han's inflight patchset at
>> http://comments.gmane.org/gmane.linux.drivers.video-input-
>> infrastructure/66435
>>
>> changes since v1:
>> - Addressed comments given by Tomasz Figa <tomasz.figa@gmail.com>
>> and Ajay kumar <ajaynumb@gmail.com>
>>
>> Vikas Sajjan (6):
>> ARM: dts: Move display-timimg information inside FIMD DT node for
>> exynos5250
>> ARM: dts: Update FIMD DT node for Exynos5 SoCs
>> ARM: dts: Add FIMD DT node to exynos5420 DTS files
>> ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
>> ARM: dts: Add DP controller DT node to exynos5420 SoC
>> ARM: dts: Add pin state information for DP HPD support to Exynos5420
>>
>> Yadwinder Singh Brar (1):
>> ARM: dts: Add basic PM domains for EXYNOS5420
>>
>> arch/arm/boot/dts/exynos5.dtsi | 21 +++++++++++
>> arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++-
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 32 +++++++++--------
>> arch/arm/boot/dts/exynos5250.dtsi | 28 ++++++---------
>> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 ++++
>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 31 ++++++++++++++++
>> arch/arm/boot/dts/exynos5420.dtsi | 55
>> +++++++++++++++++++++++++++++
>> 7 files changed, 145 insertions(+), 33 deletions(-)
>>
>> --
>> 1.7.9.5
>
> Looks good to me, will apply this whole series with fix typo, timimg? ;-)
>
Thanks.
> - Kukjin
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs
2013-07-30 11:19 ` [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs Vikas Sajjan
@ 2013-08-14 7:33 ` Kukjin Kim
2013-08-14 8:09 ` Vikas Sajjan
0 siblings, 1 reply; 23+ messages in thread
From: Kukjin Kim @ 2013-08-14 7:33 UTC (permalink / raw)
To: 'Vikas Sajjan', linux-samsung-soc
Cc: t.figa, devicetree, jg1.han, inki.dae, ajaynumb, patches, linaro-kernel
Vikas Sajjan wrote:
>
> Moves the properties of FIMD DT node which are common across Exynos5 based
> SoCs like Exynos5250 and Exxynos5420 to exynos5.dtsi
>
%s/Exxynos/Exynos
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> arch/arm/boot/dts/exynos5.dtsi | 10 ++++++++++
> arch/arm/boot/dts/exynos5250-arndale.dts | 1 +
> arch/arm/boot/dts/exynos5250.dtsi | 7 +------
> 3 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi
> b/arch/arm/boot/dts/exynos5.dtsi
> index f65e124..d464b6c 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -108,4 +108,14 @@
> interrupts = <0 42 0>;
> status = "disabled";
> };
> +
> + fimd@14400000 {
> + compatible = "samsung,exynos5250-fimd";
> + interrupt-parent = <&combiner>;
> + reg = <0x14400000 0x40000>;
> + interrupt-names = "fifo", "vsync", "lcd_sys";
> + interrupts = <18 4>, <18 5>, <18 6>;
> + status = "disabled";
> + };
> +
No need last empty line.
> };
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts
> index 96d528d..76825ef 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -519,6 +519,7 @@
> };
>
> fimd: fimd@14400000 {
> + status = "okay";
> display-timings {
> native-mode = <&timing0>;
> timing0: timing@0 {
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index ef57277..238bdb2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -630,12 +630,7 @@
> };
> };
>
> - fimd {
> - compatible = "samsung,exynos5250-fimd";
> - interrupt-parent = <&combiner>;
> - reg = <0x14400000 0x40000>;
> - interrupt-names = "fifo", "vsync", "lcd_sys";
> - interrupts = <18 4>, <18 5>, <18 6>;
> + fimd@14400000 {
> clocks = <&clock 133>, <&clock 339>;
> clock-names = "sclk_fimd", "fimd";
> };
> --
> 1.7.9.5
But you don't need to repost because let me fix when I apply.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs
2013-08-14 7:33 ` Kukjin Kim
@ 2013-08-14 8:09 ` Vikas Sajjan
0 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-08-14 8:09 UTC (permalink / raw)
To: Kukjin Kim
Cc: linux-samsung-soc, Tomasz Figa, devicetree, jg1.han, InKi Dae,
ajaynumb, Patch Tracking, linaro-kernel
Hi Kukjin,
On 14 August 2013 13:03, Kukjin Kim <kgene@kernel.org> wrote:
> Vikas Sajjan wrote:
>>
>> Moves the properties of FIMD DT node which are common across Exynos5 based
>> SoCs like Exynos5250 and Exxynos5420 to exynos5.dtsi
>>
> %s/Exxynos/Exynos
>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 10 ++++++++++
>> arch/arm/boot/dts/exynos5250-arndale.dts | 1 +
>> arch/arm/boot/dts/exynos5250.dtsi | 7 +------
>> 3 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi
>> b/arch/arm/boot/dts/exynos5.dtsi
>> index f65e124..d464b6c 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -108,4 +108,14 @@
>> interrupts = <0 42 0>;
>> status = "disabled";
>> };
>> +
>> + fimd@14400000 {
>> + compatible = "samsung,exynos5250-fimd";
>> + interrupt-parent = <&combiner>;
>> + reg = <0x14400000 0x40000>;
>> + interrupt-names = "fifo", "vsync", "lcd_sys";
>> + interrupts = <18 4>, <18 5>, <18 6>;
>> + status = "disabled";
>> + };
>> +
>
> No need last empty line.
>
>> };
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
>> b/arch/arm/boot/dts/exynos5250-arndale.dts
>> index 96d528d..76825ef 100644
>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> @@ -519,6 +519,7 @@
>> };
>>
>> fimd: fimd@14400000 {
>> + status = "okay";
>> display-timings {
>> native-mode = <&timing0>;
>> timing0: timing@0 {
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index ef57277..238bdb2 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -630,12 +630,7 @@
>> };
>> };
>>
>> - fimd {
>> - compatible = "samsung,exynos5250-fimd";
>> - interrupt-parent = <&combiner>;
>> - reg = <0x14400000 0x40000>;
>> - interrupt-names = "fifo", "vsync", "lcd_sys";
>> - interrupts = <18 4>, <18 5>, <18 6>;
>> + fimd@14400000 {
>> clocks = <&clock 133>, <&clock 339>;
>> clock-names = "sclk_fimd", "fimd";
>> };
>> --
>> 1.7.9.5
>
> But you don't need to repost because let me fix when I apply.
>
OK. Thanks.
> Thanks,
> Kukjin
>
--
Thanks and Regards
Vikas Sajjan
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-08-14 5:56 ` Kukjin Kim
@ 2013-08-14 8:16 ` Tomasz Figa
2013-08-14 8:40 ` Vikas Sajjan
0 siblings, 1 reply; 23+ messages in thread
From: Tomasz Figa @ 2013-08-14 8:16 UTC (permalink / raw)
To: Kukjin Kim
Cc: 'Tomasz Figa', 'Vikas Sajjan',
linux-samsung-soc, devicetree, jg1.han, inki.dae, ajaynumb,
patches, linaro-kernel, grant.likely, swarren, mark.rutland
On Wednesday 14 of August 2013 14:56:55 Kukjin Kim wrote:
> Tomasz Figa wrote:
> > Hi Vikas,
> >
> > On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
> > > As the display-timing information is parsed by FIMD driver, it makes
> > > sense to move the display-timimg DT node inside FIMD DT node for
> > > exynos5250
> > >
> > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> > > ---
> > >
> > > arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
> > >
> > > ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
> > > deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
> > > 100644
> > > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > @@ -262,19 +262,22 @@
> > >
> > > pinctrl-0 = <&dp_hpd>;
> > >
> > > };
> > >
> > > - display-timings {
> > > - native-mode = <&timing0>;
> > > - timing0: timing@0 {
> > > - /* 1280x800 */
> > > - clock-frequency = <50000>;
> > > - hactive = <1280>;
> > > - vactive = <800>;
> > > - hfront-porch = <4>;
> > > - hback-porch = <4>;
> > > - hsync-len = <4>;
> > > - vback-porch = <4>;
> > > - vfront-porch = <4>;
> > > - vsync-len = <4>;
> > > + fimd@14400000 {
> > > + status = "okay";
> > > + display-timings {
> > > + native-mode = <&timing0>;
> > > + timing0: timing@0 {
> > > + /* 1280x800 */
> > > + clock-frequency = <50000>;
> > > + hactive = <1280>;
> > > + vactive = <800>;
> > > + hfront-porch = <4>;
> > > + hback-porch = <4>;
> > > + hsync-len = <4>;
> > > + vback-porch = <4>;
> > > + vfront-porch = <4>;
> > > + vsync-len = <4>;
> > > + };
> > >
> > > };
> > >
> > > };
> >
> > Looks good to me, but I would like some other people from the device
> > tree mailing list to comment on node naming: Do we want to conform to
> > the recommendation of ePAPR about node naming, which states that node
> > names should be generic, not platform specific or we are free to
> > ignore it?
> The name of node looks good to me and the name had been being used for a
> long time
Like a lot of things used in device trees of ARM platforms, since we did
not have any proper processes defined for creating device tree bindings
and device trees themselves, including any recommended set of good
practices.
We are now trying to define all of this and so it's time to rethink all
the DT related things that has been added for ARM platforms since the time
DT for ARM was introduced and make sure that everything is reasonable.
> , and if we change that now, that will cause the bigger
> confusion.
Still, I think this patch can go as is and node naming can be fixed in
separate patches, including any other quirks of Exynos device trees.
So, for the whole series:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250
2013-08-14 8:16 ` Tomasz Figa
@ 2013-08-14 8:40 ` Vikas Sajjan
0 siblings, 0 replies; 23+ messages in thread
From: Vikas Sajjan @ 2013-08-14 8:40 UTC (permalink / raw)
To: Tomasz Figa
Cc: Kukjin Kim, Tomasz Figa, Vikas Sajjan, linux-samsung-soc,
devicetree, Jingoo Han, InKi Dae, Ajay kumar, patches,
linaro-kernel, Grant Likely, swarren, mark.rutland
Hi Tomasz,
On Wed, Aug 14, 2013 at 1:46 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> On Wednesday 14 of August 2013 14:56:55 Kukjin Kim wrote:
>> Tomasz Figa wrote:
>> > Hi Vikas,
>> >
>> > On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote:
>> > > As the display-timing information is parsed by FIMD driver, it makes
>> > > sense to move the display-timimg DT node inside FIMD DT node for
>> > > exynos5250
>> > >
>> > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> > > ---
>> > >
>> > > arch/arm/boot/dts/exynos5250-smdk5250.dts | 29
>> > >
>> > > ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13
>> > > deletions(-)
>> > >
>> > > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> > > b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb
>> > > 100644
>> > > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> > > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> > > @@ -262,19 +262,22 @@
>> > >
>> > > pinctrl-0 = <&dp_hpd>;
>> > >
>> > > };
>> > >
>> > > - display-timings {
>> > > - native-mode = <&timing0>;
>> > > - timing0: timing@0 {
>> > > - /* 1280x800 */
>> > > - clock-frequency = <50000>;
>> > > - hactive = <1280>;
>> > > - vactive = <800>;
>> > > - hfront-porch = <4>;
>> > > - hback-porch = <4>;
>> > > - hsync-len = <4>;
>> > > - vback-porch = <4>;
>> > > - vfront-porch = <4>;
>> > > - vsync-len = <4>;
>> > > + fimd@14400000 {
>> > > + status = "okay";
>> > > + display-timings {
>> > > + native-mode = <&timing0>;
>> > > + timing0: timing@0 {
>> > > + /* 1280x800 */
>> > > + clock-frequency = <50000>;
>> > > + hactive = <1280>;
>> > > + vactive = <800>;
>> > > + hfront-porch = <4>;
>> > > + hback-porch = <4>;
>> > > + hsync-len = <4>;
>> > > + vback-porch = <4>;
>> > > + vfront-porch = <4>;
>> > > + vsync-len = <4>;
>> > > + };
>> > >
>> > > };
>> > >
>> > > };
>> >
>> > Looks good to me, but I would like some other people from the device
>> > tree mailing list to comment on node naming: Do we want to conform to
>> > the recommendation of ePAPR about node naming, which states that node
>> > names should be generic, not platform specific or we are free to
>> > ignore it?
>> The name of node looks good to me and the name had been being used for a
>> long time
>
> Like a lot of things used in device trees of ARM platforms, since we did
> not have any proper processes defined for creating device tree bindings
> and device trees themselves, including any recommended set of good
> practices.
>
> We are now trying to define all of this and so it's time to rethink all
> the DT related things that has been added for ARM platforms since the time
> DT for ARM was introduced and make sure that everything is reasonable.
>
>> , and if we change that now, that will cause the bigger
>> confusion.
>
> Still, I think this patch can go as is and node naming can be fixed in
> separate patches, including any other quirks of Exynos device trees.
>
> So, for the whole series:
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Thanks for the review.
> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
2013-07-30 11:19 ` [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs Vikas Sajjan
@ 2013-08-26 2:57 ` Jingoo Han
2013-08-26 6:05 ` Vikas Sajjan
0 siblings, 1 reply; 23+ messages in thread
From: Jingoo Han @ 2013-08-26 2:57 UTC (permalink / raw)
To: 'Vikas Sajjan', linux-samsung-soc
Cc: kgene.kim, t.figa, devicetree, inki.dae, ajaynumb, patches,
linaro-kernel, 'Jingoo Han'
On Tuesday, July 30, 2013 8:20 PM, Vikas Sajjan wrote:
>
> Moves the properties of DP controller to exynos5.dtsi which are common
> across exynos5 SoCs like Exynos5250 and Exynos5420.
>
> The PHY DP Node is based on Jingoo Han's <jg1.han@samsung.com> patch at
> https://patchwork.linuxtv.org/patch/19189/
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> arch/arm/boot/dts/exynos5.dtsi | 11 +++++++++++
> arch/arm/boot/dts/exynos5250-arndale.dts | 3 ++-
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 ++-
> arch/arm/boot/dts/exynos5250.dtsi | 21 +++++++++------------
> 4 files changed, 24 insertions(+), 14 deletions(-)
>
[....]
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 238bdb2..1c017dc 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,20 +614,17 @@
> interrupts = <0 94 0>;
> };
>
> - dp-controller {
> - compatible = "samsung,exynos5-dp";
> - reg = <0x145b0000 0x1000>;
> - interrupts = <10 3>;
> - interrupt-parent = <&combiner>;
> + dp_phy: video-phy@10040720 {
> + compatible = "samsung,exynos5250-dp-video-phy";
> + reg = <0x10040720 4>;
> + #phy-cells = <0>;
> + };
Oops!!!
This patch should be reverted.
Or, fix patch should be re-sent.
'dp phy' driver is not yet merged to mainline kernel.
> +
> + dp-controller@145b0000 {
> clocks = <&clock 342>;
> clock-names = "dp";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - dptx-phy {
> - reg = <0x10040720>;
> - samsung,enable-mask = <1>;
> - };
> + phys = <&dp_phy>;
> + phy-names = "dp";
> };
Thus, 'dptx-phy' node should be used until dp phy driver is merged.
Vikas Sajjan,
Please test your patch on real boards when you send your patch.
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
2013-08-26 2:57 ` Jingoo Han
@ 2013-08-26 6:05 ` Vikas Sajjan
2013-09-12 10:36 ` Kukjin Kim
0 siblings, 1 reply; 23+ messages in thread
From: Vikas Sajjan @ 2013-08-26 6:05 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-samsung-soc, kgene.kim, Tomasz Figa, devicetree, InKi Dae,
Ajay kumar, Patch Tracking, linaro-kernel
Hi Mr. Jingoo Han,
On 26 August 2013 08:27, Jingoo Han <jg1.han@samsung.com> wrote:
> On Tuesday, July 30, 2013 8:20 PM, Vikas Sajjan wrote:
>>
>> Moves the properties of DP controller to exynos5.dtsi which are common
>> across exynos5 SoCs like Exynos5250 and Exynos5420.
>>
>> The PHY DP Node is based on Jingoo Han's <jg1.han@samsung.com> patch at
>> https://patchwork.linuxtv.org/patch/19189/
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 11 +++++++++++
>> arch/arm/boot/dts/exynos5250-arndale.dts | 3 ++-
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 ++-
>> arch/arm/boot/dts/exynos5250.dtsi | 21 +++++++++------------
>> 4 files changed, 24 insertions(+), 14 deletions(-)
>>
>
> [....]
>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 238bdb2..1c017dc 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -614,20 +614,17 @@
>> interrupts = <0 94 0>;
>> };
>>
>> - dp-controller {
>> - compatible = "samsung,exynos5-dp";
>> - reg = <0x145b0000 0x1000>;
>> - interrupts = <10 3>;
>> - interrupt-parent = <&combiner>;
>> + dp_phy: video-phy@10040720 {
>> + compatible = "samsung,exynos5250-dp-video-phy";
>> + reg = <0x10040720 4>;
>> + #phy-cells = <0>;
>> + };
>
> Oops!!!
>
> This patch should be reverted.
> Or, fix patch should be re-sent.
> 'dp phy' driver is not yet merged to mainline kernel.
>
As you suggest, since the DP-PHY driver is NOT yet in mainline, we may
have to keep this patch reverted till your patch series gets merged to
have DP working on exynos5 .
>
>> +
>> + dp-controller@145b0000 {
>> clocks = <&clock 342>;
>> clock-names = "dp";
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> -
>> - dptx-phy {
>> - reg = <0x10040720>;
>> - samsung,enable-mask = <1>;
>> - };
>> + phys = <&dp_phy>;
>> + phy-names = "dp";
>> };
>
> Thus, 'dptx-phy' node should be used until dp phy driver is merged.
>
> Vikas Sajjan,
> Please test your patch on real boards when you send your patch.
>
I tested the patch before sending on Exynos5250-SMDK5250 using Kishon
Vijay Abraham's series at http://lwn.net/Articles/559487/
which contains DP-PHY driver posted by you
1. phy: Add driver for Exynos DP PHY
2. video: exynos_dp: remove non-DT support for Exynos Display Port
3. video: exynos_dp: Use the generic PHY driver
>
> Best regards,
> Jingoo Han
>
>
>
--
Thanks and Regards
Vikas Sajjan
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
2013-08-26 6:05 ` Vikas Sajjan
@ 2013-09-12 10:36 ` Kukjin Kim
2013-09-12 10:56 ` Jingoo Han
0 siblings, 1 reply; 23+ messages in thread
From: Kukjin Kim @ 2013-09-12 10:36 UTC (permalink / raw)
To: 'Vikas Sajjan', 'Jingoo Han'
Cc: linux-samsung-soc, 'Tomasz Figa', 'devicetree',
'InKi Dae', 'Ajay kumar',
'Patch Tracking',
linaro-kernel
Vikas Sajjan wrote:
>
> Hi Mr. Jingoo Han,
>
> On 26 August 2013 08:27, Jingoo Han <jg1.han@samsung.com> wrote:
> > On Tuesday, July 30, 2013 8:20 PM, Vikas Sajjan wrote:
> >>
> >> Moves the properties of DP controller to exynos5.dtsi which are common
> >> across exynos5 SoCs like Exynos5250 and Exynos5420.
> >>
> >> The PHY DP Node is based on Jingoo Han's <jg1.han@samsung.com> patch at
> >> https://patchwork.linuxtv.org/patch/19189/
> >>
> >> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> >> ---
> >> arch/arm/boot/dts/exynos5.dtsi | 11 +++++++++++
> >> arch/arm/boot/dts/exynos5250-arndale.dts | 3 ++-
> >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 ++-
> >> arch/arm/boot/dts/exynos5250.dtsi | 21 +++++++++------------
> >> 4 files changed, 24 insertions(+), 14 deletions(-)
> >>
> >
> > [....]
> >
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> >> index 238bdb2..1c017dc 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -614,20 +614,17 @@
> >> interrupts = <0 94 0>;
> >> };
> >>
> >> - dp-controller {
> >> - compatible = "samsung,exynos5-dp";
> >> - reg = <0x145b0000 0x1000>;
> >> - interrupts = <10 3>;
> >> - interrupt-parent = <&combiner>;
> >> + dp_phy: video-phy@10040720 {
> >> + compatible = "samsung,exynos5250-dp-video-phy";
> >> + reg = <0x10040720 4>;
> >> + #phy-cells = <0>;
> >> + };
> >
> > Oops!!!
> >
> > This patch should be reverted.
> > Or, fix patch should be re-sent.
> > 'dp phy' driver is not yet merged to mainline kernel.
> >
>
> As you suggest, since the DP-PHY driver is NOT yet in mainline, we may
> have to keep this patch reverted till your patch series gets merged to
> have DP working on exynos5 .
>
OK, got it. Please send patch fixing this issue for v3.12. Of course, we
need this from v3.13 which will be including the DP-PHY driver.
Thanks,
Kukjin
> >
> >> +
> >> + dp-controller@145b0000 {
> >> clocks = <&clock 342>;
> >> clock-names = "dp";
> >> - #address-cells = <1>;
> >> - #size-cells = <0>;
> >> -
> >> - dptx-phy {
> >> - reg = <0x10040720>;
> >> - samsung,enable-mask = <1>;
> >> - };
> >> + phys = <&dp_phy>;
> >> + phy-names = "dp";
> >> };
> >
> > Thus, 'dptx-phy' node should be used until dp phy driver is merged.
> >
> > Vikas Sajjan,
> > Please test your patch on real boards when you send your patch.
> >
>
> I tested the patch before sending on Exynos5250-SMDK5250 using Kishon
> Vijay Abraham's series at http://lwn.net/Articles/559487/
> which contains DP-PHY driver posted by you
> 1. phy: Add driver for Exynos DP PHY
> 2. video: exynos_dp: remove non-DT support for Exynos Display Port
> 3. video: exynos_dp: Use the generic PHY driver
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
2013-09-12 10:36 ` Kukjin Kim
@ 2013-09-12 10:56 ` Jingoo Han
0 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2013-09-12 10:56 UTC (permalink / raw)
To: 'Kukjin Kim', 'Vikas Sajjan'
Cc: linux-samsung-soc, 'Tomasz Figa', 'devicetree',
'InKi Dae', 'Ajay kumar',
'Patch Tracking', linaro-kernel, 'Jingoo Han'
On Thursday, September 12, 2013 7:37 PM, Kukjin Kim wrote:
>
> Vikas Sajjan wrote:
> >
> > Hi Mr. Jingoo Han,
> >
> > On 26 August 2013 08:27, Jingoo Han <jg1.han@samsung.com> wrote:
[.....]
> > >
> > > Oops!!!
> > >
> > > This patch should be reverted.
> > > Or, fix patch should be re-sent.
> > > 'dp phy' driver is not yet merged to mainline kernel.
> > >
> >
> > As you suggest, since the DP-PHY driver is NOT yet in mainline, we may
> > have to keep this patch reverted till your patch series gets merged to
> > have DP working on exynos5 .
> >
> OK, got it. Please send patch fixing this issue for v3.12. Of course, we
> need this from v3.13 which will be including the DP-PHY driver.
>
I already sent the patch fixing this.
([PATCH V2] ARM: dts: Remove DP PHY node from exynos5250.dtsi)
Please refer to the following. :-)
http://www.spinics.net/lists/linux-samsung-soc/msg22023.html
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2013-09-12 10:56 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Vikas Sajjan
2013-08-01 14:49 ` Tomasz Figa
2013-08-05 10:04 ` Vikas Sajjan
2013-08-05 10:29 ` Sachin Kamat
2013-08-12 6:57 ` Vikas Sajjan
2013-08-14 5:56 ` Kukjin Kim
2013-08-14 8:16 ` Tomasz Figa
2013-08-14 8:40 ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs Vikas Sajjan
2013-08-14 7:33 ` Kukjin Kim
2013-08-14 8:09 ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 3/7] ARM: dts: Add basic PM domains for EXYNOS5420 Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 4/7] ARM: dts: Add FIMD DT node to exynos5420 DTS files Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs Vikas Sajjan
2013-08-26 2:57 ` Jingoo Han
2013-08-26 6:05 ` Vikas Sajjan
2013-09-12 10:36 ` Kukjin Kim
2013-09-12 10:56 ` Jingoo Han
2013-07-30 11:19 ` [PATCH v2 6/7] ARM: dts: Add DP controller DT node to exynos5420 SoC Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 7/7] ARM: dts: Add pin state information for DP HPD support to Exynos5420 Vikas Sajjan
2013-08-14 5:58 ` [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Kukjin Kim
2013-08-14 6:00 ` Vikas Sajjan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.