From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 08/18] PVH xen: tools changes to create PVH
 domain
Date: Wed, 31 Jul 2013 12:32:26 +0100
Message-ID: <1375270346.7382.4.camel@kazak.uk.xensource.com>
References: <1369445137-19755-1-git-send-email-mukesh.rathor@oracle.com>
	<1369445137-19755-9-git-send-email-mukesh.rathor@oracle.com>
	<1371049088.24512.450.camel@zakaz.uk.xensource.com>
	<20130730180617.714dfac3@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130730180617.714dfac3@mantra.us.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2013-07-30 at 18:06 -0700, Mukesh Rathor wrote:
> On Wed, 12 Jun 2013 15:58:08 +0100
> Ian Campbell <Ian.Campbell@citrix.com> wrote:
> 
> > On Fri, 2013-05-24 at 18:25 -0700, Mukesh Rathor wrote:
> ... 
> > > +    }
> > > +
> > >      dom = xc_dom_allocate(ctx->xch, state->pv_cmdline,
> > > info->u.pv.features); if (!dom) {
> > >          LOGE(ERROR, "xc_dom_allocate failed");
> > > @@ -370,6 +384,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t
> > > domid, }
> > >  
> > >      dom->flags = flags;
> > > +    dom->pvh_enabled = is_pvh;
> > 
> > Not part of the flags?
> 
> I'd have liked to use the flags, but with all due respect, when a field 
> is named "flags", a search for which yields 800 hits, and there is no
> comment, and the type is ulong, it is impossible for someone to
> understand and reverse engineer it? Can you tell me if it's a bit field,
> enum of some sort, or even where it's used? I can't grep/cscope such
> generic field name...

Well, obviously you grep/cscope for the type of the containing struct
and then look within it, it's hardly rocket science.

As it happens these flags correspond exactly to the struct start_info
flags which are a bunch of SIF_* things, so in this case putting pvh
there isn't appropriate.

Ian.