From: Steven Rostedt <rostedt@goodmis.org>
To: David Sharp <dhsharp@google.com>
Cc: Andrew Vagin <avagin@openvz.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] tracing: a few fields of struct trace_iterator are zeroed by mistake
Date: Fri, 02 Aug 2013 14:32:35 -0400 [thread overview]
Message-ID: <1375468355.22073.9.camel@gandalf.local.home> (raw)
In-Reply-To: <CAJL_ektQ=q2T6CUR0bKig088DWaOSUd-yek2S_dT3fjRRfrf0Q@mail.gmail.com>
On Fri, 2013-08-02 at 11:15 -0700, David Sharp wrote:
> Wow. That is a terrible hack. Thanks for noticing it.
Why thank you :-)
It's a hack from doing things that way else where and long ago.
>
> If I may suggest a way better idea: put these zeroed-in-pipe_read
> members in an embedded anonymous structure, and zero the structure in
> pipe_read.
Sure, sounds like a fix for 3.12.
-- Steve
next prev parent reply other threads:[~2013-08-02 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 17:16 [PATCH] tracing: a few fields of struct trace_iterator are zeroed by mistake Andrew Vagin
2013-08-02 18:15 ` David Sharp
2013-08-02 18:32 ` Steven Rostedt [this message]
2013-08-03 1:21 ` Steven Rostedt
2013-08-03 1:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375468355.22073.9.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arjan@linux.intel.com \
--cc=avagin@openvz.org \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=hiraku.toyooka.gu@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.