All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Runzhen Wang <runzhen@linux.vnet.ibm.com>
Subject: [PATCH 6/9] perf kvm: add min and max stats to display
Date: Fri,  2 Aug 2013 14:05:44 -0600	[thread overview]
Message-ID: <1375473947-64285-7-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1375473947-64285-1-git-send-email-dsahern@gmail.com>

Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Runzhen Wang <runzhen@linux.vnet.ibm.com>
---
 tools/perf/builtin-kvm.c |   21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 12f7593..5c6e3cd 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -337,14 +337,19 @@ static void clear_events_cache_stats(struct list_head *kvm_events_cache)
 	struct list_head *head;
 	struct kvm_event *event;
 	unsigned int i;
+	int j;
 
 	for (i = 0; i < EVENTS_CACHE_SIZE; i++) {
 		head = &kvm_events_cache[i];
 		list_for_each_entry(event, head, hash_entry) {
 			/* reset stats for event */
-			memset(&event->total, 0, sizeof(event->total));
-			memset(event->vcpu, 0,
-			       event->max_vcpu * sizeof(*event->vcpu));
+			event->total.time = 0;
+			init_stats(&event->total.stats);
+
+			for (j = 0; j < event->max_vcpu; ++j) {
+				event->vcpu[j].time = 0;
+				init_stats(&event->vcpu[j].stats);
+			}
 		}
 	}
 }
@@ -718,6 +723,7 @@ static void print_result(struct perf_kvm_stat *kvm)
 	char decode[20];
 	struct kvm_event *event;
 	int vcpu = kvm->trace_vcpu;
+	struct kvm_event_stats *kvm_stats;
 
 	if (kvm->live) {
 		puts(CONSOLE_CLEAR);
@@ -731,6 +737,8 @@ static void print_result(struct perf_kvm_stat *kvm)
 	pr_info("%9s ", "Samples%");
 
 	pr_info("%9s ", "Time%");
+	pr_info("%10s ", "Min Time");
+	pr_info("%10s ", "Max Time");
 	pr_info("%16s ", "Avg time");
 	pr_info("\n\n");
 
@@ -740,11 +748,18 @@ static void print_result(struct perf_kvm_stat *kvm)
 		ecount = get_event_count(event, vcpu);
 		etime = get_event_time(event, vcpu);
 
+		if (vcpu == -1)
+			kvm_stats = &event->total;
+		else
+			kvm_stats = &event->vcpu[vcpu];
+
 		kvm->events_ops->decode_key(kvm, &event->key, decode);
 		pr_info("%20s ", decode);
 		pr_info("%10llu ", (unsigned long long)ecount);
 		pr_info("%8.2f%% ", (double)ecount / kvm->total_count * 100);
 		pr_info("%8.2f%% ", (double)etime / kvm->total_time * 100);
+		pr_info("%8" PRIu64 "us ", kvm_stats->stats.min / 1000);
+		pr_info("%8" PRIu64 "us ", kvm_stats->stats.max / 1000);
 		pr_info("%9.2fus ( +-%7.2f%% )", (double)etime / ecount/1e3,
 			kvm_event_rel_stddev(vcpu, event));
 		pr_info("\n");
-- 
1.7.10.1


  parent reply	other threads:[~2013-08-02 20:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 20:05 [PATCH 0/9] perf: kvm live mode David Ahern
2013-08-02 20:05 ` [PATCH 1/9] perf top: move CONSOLE_CLEAR to header file David Ahern
2013-08-12 10:19   ` [tip:perf/core] " tip-bot for David Ahern
2013-08-02 20:05 ` [PATCH 2/9] perf stats: add max and min stats David Ahern
2013-08-05  6:02   ` Xiao Guangrong
2013-08-12 10:19   ` [tip:perf/core] perf stats: Add " tip-bot for David Ahern
2013-08-02 20:05 ` [PATCH 3/9] perf session: export a few functions for event processing David Ahern
2013-08-12 10:19   ` [tip:perf/core] perf session: Export " tip-bot for David Ahern
2013-08-02 20:05 ` [PATCH 4/9] perf kvm: split out tracepoints from record args David Ahern
2013-08-05  5:09   ` Xiao Guangrong
2013-08-05 15:41     ` Arnaldo Carvalho de Melo
2013-08-12 10:19   ` [tip:perf/core] perf kvm: Split " tip-bot for David Ahern
2013-08-02 20:05 ` [PATCH 5/9] perf kvm: add live mode - v3 David Ahern
2013-08-05  5:53   ` Xiao Guangrong
2013-08-05 14:43     ` David Ahern
2013-08-02 20:05 ` David Ahern [this message]
2013-08-05  6:09   ` [PATCH 6/9] perf kvm: add min and max stats to display Xiao Guangrong
2013-08-05 14:44     ` David Ahern
2013-08-02 20:05 ` [PATCH 7/9] perf kvm: option to print events that exceed a threshold David Ahern
2013-08-05  6:39   ` Xiao Guangrong
2013-08-05 14:49     ` David Ahern
2013-08-02 20:05 ` [PATCH 8/9] perf kvm: debug for missing vmexit/vmentry event David Ahern
2013-08-05  6:53   ` Xiao Guangrong
2013-08-05 15:00     ` David Ahern
2013-08-02 20:05 ` [PATCH 9/9] perf kvm stat report: Add option to analyze specific VM David Ahern
2013-08-05  6:57   ` Xiao Guangrong
2013-08-05 14:57     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375473947-64285-7-git-send-email-dsahern@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=runzhen@linux.vnet.ibm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.