From mboxrd@z Thu Jan 1 00:00:00 1970 From: zwu.kernel@gmail.com Subject: [PATCH v4 06/10] VFS hot tracking: Add a /proc interface to make the interval tunable Date: Mon, 5 Aug 2013 22:49:56 +0800 Message-ID: <1375714200-23944-7-git-send-email-zwu.kernel@gmail.com> References: <1375714200-23944-1-git-send-email-zwu.kernel@gmail.com> Cc: linux-fsdevel@vger.kernel.org, sekharan@us.ibm.com, Zhi Yong Wu To: viro@zeniv.linux.org.uk Return-path: Received: from e37.co.us.ibm.com ([32.97.110.158]:56623 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483Ab3HEOus (ORCPT ); Mon, 5 Aug 2013 10:50:48 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 5 Aug 2013 08:50:47 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id EA82A19D803E for ; Mon, 5 Aug 2013 08:50:30 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r75EofGs155696 for ; Mon, 5 Aug 2013 08:50:41 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r75EnVPw026114 for ; Mon, 5 Aug 2013 08:49:32 -0600 In-Reply-To: <1375714200-23944-1-git-send-email-zwu.kernel@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Zhi Yong Wu Add a proc interface hot-update-interval under the dir /proc/sys/fs/ in order to turn HOT_UPDATE_INTERVAL into a tunable parameter. Signed-off-by: Chandra Seetharaman Signed-off-by: Zhi Yong Wu --- fs/hot_tracking.c | 7 +++++-- fs/hot_tracking.h | 2 -- include/linux/hot_tracking.h | 3 +++ kernel/sysctl.c | 7 +++++++ 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/fs/hot_tracking.c b/fs/hot_tracking.c index 037d5db..a3742b7 100644 --- a/fs/hot_tracking.c +++ b/fs/hot_tracking.c @@ -15,6 +15,9 @@ #include #include "hot_tracking.h" +int sysctl_hot_update_interval __read_mostly = 150; +EXPORT_SYMBOL_GPL(sysctl_hot_update_interval); + /* kmem_cache pointers for slab caches */ static struct kmem_cache *hot_inode_item_cachep __read_mostly; static struct kmem_cache *hot_range_item_cachep __read_mostly; @@ -594,7 +597,7 @@ static void hot_update_worker(struct work_struct *work) /* Instert next delayed work */ queue_delayed_work(root->update_wq, &root->update_work, - msecs_to_jiffies(HOT_UPDATE_INTERVAL * MSEC_PER_SEC)); + msecs_to_jiffies(sysctl_hot_update_interval * MSEC_PER_SEC)); } /* @@ -729,7 +732,7 @@ static struct hot_info *hot_tree_init(struct super_block *sb) /* Initialize hot tracking wq and arm one delayed work */ INIT_DELAYED_WORK(&root->update_work, hot_update_worker); queue_delayed_work(root->update_wq, &root->update_work, - msecs_to_jiffies(HOT_UPDATE_INTERVAL * MSEC_PER_SEC)); + msecs_to_jiffies(sysctl_hot_update_interval * MSEC_PER_SEC)); /* Register a shrinker callback */ root->hot_shrink.shrink = hot_track_prune; diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h index 0be7621..23b1339 100644 --- a/fs/hot_tracking.h +++ b/fs/hot_tracking.h @@ -15,8 +15,6 @@ #include #include -#define HOT_UPDATE_INTERVAL 150 - /* size of sub-file ranges */ #define RANGE_BITS 20 #define FREQ_POWER 4 diff --git a/include/linux/hot_tracking.h b/include/linux/hot_tracking.h index e480f7d..92e3547 100644 --- a/include/linux/hot_tracking.h +++ b/include/linux/hot_tracking.h @@ -101,6 +101,9 @@ struct hot_info { struct shrinker hot_shrink; }; +/* set how often to update temperatures (seconds) */ +extern int sysctl_hot_update_interval; + /* * Hot data tracking ioctls: * diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 07f6fc4..398cc05 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1631,6 +1631,13 @@ static struct ctl_table fs_table[] = { .proc_handler = &pipe_proc_fn, .extra1 = &pipe_min_size, }, + { + .procname = "hot-update-interval", + .data = &sysctl_hot_update_interval, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec, + }, { } }; -- 1.7.11.7